keighl / postmark Goto Github PK

This will allow us to remove the step of parsing the list of templates at application startup and using an in process cache of template names to template IDs.

How do I use a template alias?

I am more than happy to do the work, I just want a greenlight that the feature is a valid addition to the package.

I have migrated my application to using the dep tool for package management and by default it detected the tag versions over using the master branch and forced my version of postmark to 1.1.1.

This version was missing the fix that was applied back in June and so to get things working again I had to use the master branch for the version. I know this library doesn't change that often but tagging a new version will help with stability in the future. This way major work could happen in the package and applications wouldn't be impacted unless they linked directly to the master branch instead of a tagged version.

Looks like you are missing the ReceivedAt field for the MessageEvent structure.

The current documentation has the field defined.

At the moment the Client is a struct.

Perhaps we could move that to an interface, allowing easy mocking of the requests for testing?

Hi, thanks for making this useful repo!

I see a number of unanswered pull requests and I wonder if this repo should be considered abandoned?

If you're not interested in maintaining the project any more, that's cool, but would consider looking for someone who would?

It would be helpful to know either way as we'd like to know whether to use this project or one of several well maintained forks.

Again, thanks for your work getting this started!

This will allow for version referencing when using the new go modules.

Modules#version-selection

Postmark produces the following error for this:

{
   "ErrorCode":10,
   "Message":"Please do not include Account API Token for Server API Token calls."
}

Looks like there is a bug in the library that is trying to json unmarshal an OutboundMessage.Attachment into the type postmark.Attachment.

The exact error message I am getting is json: cannot unmarshal string into Go struct field OutboundMessage.Attachments of type postmark.Attachment

Let me know if you want me to provide more information or if you want I can submit a PR to fix this.

In client.SendEmail there is a check in response.ErrorCode != 0 for returning an error. This is not the case for client.SendTemplatedEmail, see: