keiranking / phil Goto Github PK

It would be great to see a percentage amount of black blocks vs letter blocks displayed somewhere. We know that keeping it in a certain range is preferred and it would be helpful to see that number as we're tweaking the grid.

Autofill button does nothing.

Also....is there a way to adjust the size of the grid, or are we limited to 15x15?

Hi Keiran,

First of all, thank you for making this tool! It's awesome!

One question (not really an issue, hope that is okay) -- is there a way to create a puzzle that contains a rebus?

Thanks,
Ruth

It's way too easy to touch one of these buttons accidentally and wipe everything out. A confirmation would be a simple way to resolve this.

Following the readme, I did brew install emscripten. When it was complete, I tried the make xwsolve.js and receive the following:

third_party/glucose-3.0/simp  master ✔                                                                                                                   156d
➢ make xwsolve.js
Compiling: /Users/caleb/Documents/git/thompsch/Phil/third_party/glucose-3.0/simp/Main.o
WARNING:root:LLVM version appears incorrect (seeing "9.1", expected "6.0")
CRITICAL:root:fastcomp in use, but LLVM has not been built with the JavaScript backend as a target, llc reports:
===========================================================================
(no targets could be identified: [Errno 2] No such file or directory)
===========================================================================
CRITICAL:root:you can fall back to the older (pre-fastcomp) compiler core, although that is not recommended, see http://kripken.github.io/emscripten-site/docs/building_from_source/LLVM-Backend.html
INFO:root:(Emscripten: Running sanity checks)
ERROR:root:Cannot find /usr/bin/llvm-link, check the paths in ~/.emscripten
make: *** [/Users/caleb/Documents/git/thompsch/Phil/third_party/glucose-3.0/simp/Main.o] Error 1

Hi there -- my mom would like to use this to construct puzzles, but she only has an iPad. When using the website on mobile, the keyboard does not appear, presumably because the grid is not seen as being "input". I'll probably try to look at this on my own at some point and submit a PR but just wondering if there's a reason it's not supported, or if a small quick fix is possible. Thanks!

I really like the idea and the interface for this tool. How difficult would it be to support puzzles of a different size. Say a 21 X 21?

I'm an okay programmer by trade. Maybe I could make a pull request if you can point me in the right direction.

Love the app, especially as you have taken the time to integrate so many export options.

Would love to be able to add circles.

Also, what about specifying the grid size?

Clues that contain a period character (.) in the middle of them are sometimes cut off after that point in exported .puz files.

I'm not sure if there's already a way to do this and I'm just missing it... in the image below, the number 19 shouldn't be there, right? There's no word that starts there, either down or across.

I'd be glad to take a look and work on this (this is an incredible tool!), I just don't want to duplicate work if there's already a way.

I believe the relevant code is here:

A number of my clues end up just crammed on top of each other in the bottom left corner of the page, unreadable

Since you're working in Javascript, I was thinking it might be really cool if you could try serving this page with the "Github Pages" function. It does serve static HTML/CSS/Javascript files, even though the resources for it heavily push it as a Jekyll blog host.

Here's a gist to copy master to a branch that makes a web page: https://gist.github.com/mandiwise/44d1edce18f2ffb14f63

Once that's done, you should be able to reach your page from any browser over http://keiranking.github.io/kCrossword

(note it takes github about 10 minutes to start serving an update over github.io)

When a clue has more than one period in it, it is truncated immediately before the second period when exported to PUZ format.

For instance, a crossword is created with 1 across being "First U.S. President".
It is exported to PUZ format.
When loaded into any program that supports PUZ format, the clue becomes "First U.S"
I have tested this with:
Across Lite Mac and Windows versions
Puzzle Solver (https://www.crosswordsolver.info/)
HTML5 PUZ file reader (http://derekslager.com/puz/)
loading back into Phil from the PUZ file

Loving this program! I know it's designed for NY Times grids but I'm trying to use it for an Aussie/British style layout and it's having problems working out where the clues are. I've taken a browse through the code and it seems that it's only checking whether the previous square is black before deciding there's a clue there - which in the rest of the world's grids means a whole lot of extra numbers.

I've attached a demo .pdf to show what I mean: blank-grid.pdf

I've taken a look at the code and I think I've worked out a simple fix, one that checks whether a black square is before AND after each white square before determining its viability. This should still leave the NY-times version unchanged while supporting other grid layouts!

cross.js, lines 542 & 543:

isDown = i == 0 || xw.fill[i - 1][j] == BLACK && i == xw.rows - 1 || xw.fill[i + 1][j] != BLACK; 
isAcross = j == 0 || xw.fill[i][j - 1] == BLACK && j == xw.cols - 1 || xw.fill[i][j + 1] != BLACK;

Hope it helps,
Dan

After solving the issue I mentioned in #17, I successfully built the .js and .wasm.

But trying to run it I see in console

[Warning] Invalid function pointer called with signature 'iii'. Perhaps this is an invalid value (e.g. caused by calling a virtual method on a NULL pointer)? Or calling a function with an incorrect type, which will fail? (it is worth building your source files with -Werror (warnings are errors), as warnings can indicate undefined behavior which can cause this) (xwsolve.js, line 1)

What is the purpose of auto-fill? Even on your website I can't tell what it does (and FWIW it does not spew this error)

I was trying out Phil and found it delightful how quickly I was making progress on an idea. Then I accidentally clicked on the "generate pattern" button, and poof! everything disappeared except the title. Is there a way to undo an action? I tried CTRL-Z to no avail...