The itg_tools from kemcbride

itg_tools's People

Contributors

Watchers

itg_tools's Issues

bad loop iterating could find non-song items

hey hey, did you know? that your non-careful loop iterating over items?? is dangeorus and scary? beacuse sometimes packs have banners and stuff. and then it'll error every time. jeesh.

...
Traceback (most recent call last):
  File "prep.py", line 19, in <module>
    main(args.path)
  File "prep.py", line 11, in main
    patch_audio_quality('/'.join([path, song]))
  File "/home/kelly/github/itg_usb_prep/file_size.py", line 16, in patch_audio_quality
    f for f in os.listdir(sm_path)
OSError: [Errno 20] Not a directory: 'SV2/banner.png'

really amazing bug

did you know? that if your subprocess has a nonzero return code? python raises an exception?
this basically means my dumb if statement for a nonzero code is useless.

kelly:itg_usb_prep$ python prep.py dog
SKIPPING: One.ogg // 2261923b
Fancy.ogg
True
Traceback (most recent call last):
  File "prep.py", line 19, in <module>
    main(args.path)
  File "prep.py", line 11, in main
    patch_audio_quality('/'.join([path, song]))
  File "/home/kelly/github/itg_usb_prep/file_size.py", line 26, in patch_audio_quality
    passes_check = call_avconv(sm_path, af)
  File "/home/kelly/github/itg_usb_prep/file_size.py", line 50, in call_avconv
    stdout=FNULL, stderr=FNULL)
  File "/usr/lib/python2.7/subprocess.py", line 541, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['avconv', '-i', 'dog/Fancy/Fancy.ogg', '-c:a:0', 'libvorbis', '-qscale:a', '3', 'dog/Fancy/temp', '-y']' retur
ned non-zero exit status 1

Recommend Projects