SocialLinkDto doesn't implement the IDto interface like the other DTO classes. :)

Doesn't have extra functionality but would make it more consistent.

Currently the business logic is in Kentico project which should be named differently. I would use something related to MedioClinic.

I guess we can remove them from the HTML as they are not crucial - and the steps to display them is already covered in website's footer, right?

Expected result

List of doctors should link through to the detail page for the specific doctor.

Additional context

When running the code 'as is' without making any changes, the list of doctors does not link through to the detail pages properly.

Resources

• http://localhost/kentico12_medioclinic/en-us/doctors

Motivation

Lambda registrations make sense for most-often used services. They reportedly yield a 10x performance improvement.

Proposed solution

Re-implement AutofacConfig as per https://autofac.readthedocs.io/en/latest/best-practices/index.html#register-frequently-used-components-with-lambdas

Motivation

In both the pre-production version and the RTM version, following the instructions to make preview work is obviously not enough.

Solution

1. Attach the Medio Clinic to the full source solution
2. Add some BPs to "usual suspect" spots
3. Attach VS to an appropriate w3wp.exe process
4. Navigate to the admin UI -> Pages
5. Switch the display mode to "preview"
6. Click on an arbitrary page
7. Wait for the debugger to intercept any of the BPs
8. Find out what went wrong & fix
9. Commit to a feature branch
10. Ask for review
11. Merge

In MVC best practice is to put site specific resource strings into resource file located under App_Data//Resources. I can see that no file is currently here and Localize extension method is not used anywhere so it's probably not needed. Take this just as heads up not to forget to add this file if needed.

https://docs.kentico.com/k12/multilingual-websites/setting-up-a-multilingual-user-interface/creating-site-specific-resource-strings

In

    public class EmailViewModel : IViewModel
    {
        [Required(ErrorMessage = "general.requireemail")]
        [DisplayName("general.emailaddress")]
        [DataType(DataType.EmailAddress)]
        [EmailAddress(ErrorMessage = "Models.EmailFormat")]
        [MaxLength(100, ErrorMessage = "Models.MaxLength")]
        public string Email { get; set; }
    }

I would expect general.requireemail to be General.RequireEmail to match the Models.EmailFormat format and it is better for readability as well.

This issue present in multiple view models, not just the EmailViewModel I referenced.

Lowercase only syntax is also used in views:

        <div class="col l6 m12 s12">
                <p>
                    <a href="@Url.Action("Register", "Account")" class="kn-smaller">@Html.Localize("Views.Account.RegisterNow")</a>
                    <div class="col s12">
                        <div class="row kn-row-margin">
                            <div class="input-field col s6">
                                @Html.TextBoxFor(m => m.Data.Email, new { @class = "validate", placeholder = Html.DisplayNameFor(m => m.Data.Email) })
                            </div>
                        </div>
                        <div class="row kn-row-margin">
                            <div>
                                <button class="btn waves-effect waves-light red darken-3" type="submit" name="action">@Html.Localize("passreset.title")</button>
                            </div>
                        </div>
                    </div>
                    <a href="@Url.Action("Signin", "Account")" class="kn-smaller">@Html.Localize("Views.Account.ForgotPassword.AlreadyMember")</a>
                </p>

            </div>

Motivation

On certain circumstances, requests to /notfound end up with a generic 403 instead of a custom-tailored not found page.

Resolution

Find out the root cause (IIS logging, research, symptom triage), fix & make edits in the course eventually.

Motivation

The repo should meet the standard OS project requirements.

Design guidelines

Add a README.md, Code of Conduct, license file, issue templates, PR template. Enforce feature branches by making master protected. Consider turning off unnecessary GH features (e.g. projects).

I'm at the part in the tutorial where I should be able to see the home page. But I get this error.

Could not load file or assembly 'DotNetOpenAuth.Core, Version=4.1.0.0, Culture=neutral, PublicKeyToken=2780ccd10d57b246' or one of its dependencies. The system cannot find the file specified.

Im having issues getting the database file that was included to restore on the current version of SSMS. Any help would be greatly appreciated.

https://github.com/Kentico/training-kentico-k12/network/alerts

Please separate the services from the repository. You were talking about MVC best practices when implementing Repository instead of using generated providers.

But an even more important best practice is to separate the service layer from the data layer. Which is clearly ignored here.

There are several unused using throughout project, there is typo in MultuCultureMvcRouteHandler file name and in DocumentQueryService is else on line with curly bracket.

The ViewbagMessage is not actually using ViewBag and has nothing to do with it (which is a good thing) so I would avoid confusion and renamed it to something more appropriate (e.g. MessageView ...)

document.querySelector instead of document.querySelectorAll is used in the master and builder branches, this causes that only one dropdown can be initialized with dropdown content. This is in the main.js file.

Walked into this bug by following the Kentico MVC Identity tutorial from the master branch.

Just a quick 'up and running' nit-pick, but my Local IIS either didn't come with a "Default Web Site" or I deleted it years ago when I first installed it. I've been used to setting my Kentico sites up like they would appear on production. I'd normally use admin.medioclinic.develop, and www.medioclinic.develop are my usual local development names, and attempting to do this on the training had some bad results and caused me to have to start back over from the begining.

It would be nice to have some better documentation or at least a link to how to set that up on the readme.md like the following:

Open IIS and find the website named "Default Web Site"
If one doesn't exist, you must create one.
Make sure that it's using an app pool named DefaultAppPool
Set the Physical Path: %SystemDrive%\Inetpub\wwwroot
Leave everything else blank and hit ok.

From there right click the "Default Web Site" and click add application.
Add the physical path of the CMS directory in this project. Set alias to "Kentico12_Admin"
Repeat the above process for the MedioClinic folder with an alias of "Kentico12_MedioClinic"

Thanks!

I just went through the creation of the Landing pages as well as the advanced widgets and when I try to load the following view for the landing page...

`@section Styles {
@Html.Kentico().PageBuilderStyles()
}

@section Scripts {
@Html.Kentico().PageBuilderScripts()
}`

I get the following error:

The following sections have been defined but have not been rendered for the layout page "~/Views/Shared/_Layout.cshtml": "Styles".

Is this correct - or should this be moved to services & implement the IService instead?
Thanks for looking into it.
L.

Motivation

This looks like a common use case:
Not all of the website content might exist in all culture variants. In this case, developers might want to display content in default culture. The training website in the Essentials module should show how to achieve this behavior.

Example submitted by a customer:
For example, I have 5 doctors in my clinic, all of them having an English description but only one of them has been translated into Spanish.
In my live site, in the English culture, I see 5 doctors but when I switch to Spanish, I see only 1 doctor while I would like to see the 4 others even if their associated information is in English.

Proposed solution

Ideally, this behavior will be implemented globally, e.g., by calling CombineWithDefaultCulture() in DocumentQueryService.

The menu repository uses a slightly different approach to get the custom document query service. Was there any reason for that?

Or can the code be updated so that it inherits from the base repository and matches the approach used on the rest of the pages in the first module? E.g., HomeSectionRepo

Brief bug description

What went wrong?
The identifier at TwoColumnFourtySixtySectionController - MedioClinic.SectionFourtySixty.TwoColumn breaks the naming convention set for the project, (e.g., MedioClinic.Section.TwoColumnSixtyFourty).

Hi,
When I compile MVC application, I get this error:
"could not load file or assembly 'cms.application dashboard.web.ui, version=12.0.0.0, culture=neutral, publickeytoken=834b12a258f213f9' or one of its dependencies"
Please let me know how I can fix it?

Thanks,
Zoya

There are some repositories that are getting documents by TopN(1) and FirstOrDefault. This can lead to inconsistent results when using staging.

When preview is enabled the Published call can be left out and LatestVersion doesn't need true as parameter because true is default value of parameter. When preview is not enabled the query should call Published().PublishedVersion() methods.

I get this error trying to load the admin for the training site. The forward facing site loads fine.

HTTP Error 401.3 - Unauthorized
You do not have permission to view this directory or page because of the access control list (ACL) configuration or encryption settings for this resource on the Web server.

Brief bug description

Language selector shows incorrect language.

Repro steps

1. Make sure you browse the MedioClinic page on English.
2. Go to 'Contact Us'
3. Click on the language selector
4. Select spanish
5. You get a 404 page, because 'Contact Us' does not exist in spanish
6. Read the language letter on the language selector. (DE for me, but there is no German setup in Kentico)

Expected behavior

The language selector properly shows "EN".

Test environment

• Platform/OS: Windows 10, Default vanilla installation of the Demo
• Browser Chrome
• Commit 827abeb

Screenshots

I am trying to follow along the tutorials, but the only version of the site I can find is the completed one. Is there a way to download a version of the site that matches up with the starting point of the tutorials? It doesn't appear to be a basic kentico installation,

oh man... now I am getting a 404 on the home page.

I believe that having:

UserManager = userManager ?? throw new ArgumentNullException(nameof(userManager));
SignInManager = signInManager ?? throw new ArgumentNullException(nameof(signInManager));
 AuthenticationManager = authenticationManager ?? throw new ArgumentNullException(nameof(authenticationManager));
ErrorHelperService = errorHelperService ?? throw new ArgumentNullException(nameof(errorHelperService));
LocalizationService = localizationService ?? throw new ArgumentNullException(nameof(localizationService));
AvatarRepository = avatarRepository ?? throw new ArgumentNullException(nameof(avatarRepository));

is not necessary as DI container should throw an exception if it cannot instantiate class and thus it should never reach constructor.

I would suggest veryfing this and probably removing the exceptions from constructors.

Motivation

With the way that this implementation differs from how Dancing Goat has been implemented, it would be good to see how we can unit test the Business and MedioClinic projects.

I believe this would help in convincing developers to use MVC as one of the major benefits for migrating to MVC.

At least enable page tab for 1 page
At least implement 1 editable text box, widget, form in page tab.

I would rather add using instead of specifying whole type name like this CMS.DocumentEngine.Types.Training.Doctor.

Brief bug description

I suspect a minor code error in Views/Doctors/Detail.cshtml. The following line...

<img src="@Url.KenticoImageUrl(Model.Data.Doctor.Photo.GetPath())" alt="Doctor's photo" />

Repro steps

1. Add repo to project solution
2. Attempt to build
3. See error

Expected behavior

I believe the correct code would be...

<img src="@Url.Kentico().ImageUrl(Model.Data.Doctor.Photo.GetPath(), SizeConstraint.Empty)" alt="Doctor's photo"/>

Test environment

• Version - Kentico v12.0

The RouteConfig seems to instantiate the MultiCultureMvcRouteHandler handler twice. Is this intentional? Thanks for looking into it.