Giter VIP home page Giter VIP logo

image's People

Contributors

ddjikic avatar elef1970 avatar kevbaldwyn avatar kevinkhill avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

image's Issues

Image::path function repeat the first image inside a loop

Consider this scenary:

$images is an array with to strings 1.jpg and 2.jpg

@foreach ($images as $img)
<img src="{{ Image::path($img, 'resizeCrop', 350, 350) }}" />
@Endforeach

There is the generated url for each image

1 = _img?img=1.jpg&transform=resizeCrop,350,350
2 = _img?img=1.jpg&transform=resizeCrop,350,350img=2.jpg&transform=resizeCrop,350,350

The url of 2.jpg is appended to first url.

I've check the path function and it seems to be related to pathString member of Image object. Maybe it have to be reset to route default value on each call?

'Undefined index: Imagecow_detection'

Hi,
I keep on having the same exception:

'ErrorException' with message 'Undefined index: Imagecow_detection' in /home/frontoff/public_html/laravel/vendor/kevbaldwyn/image/src/KevBaldwyn/Image/Image.php:265

Even if I don't use responsive method. How can I fix this ?
Thanks in advance.

no decode delegate for this image format `Gd'

Hi i have an issue when i use

Image::path('/someimage.jpg', 'resizeCrop', 400, 200)

i get no decode delegate for this image format Gd' or no decode delegate for this image formatImagick'
i have installed imagic and gd and they are shown with php_info

Laravel 5x compatibility?

Just found this. Looks amazing. Thanks for putting together.

A quickie... It's it L5 compatible?

Thanks. Keep it up!

There was an error with the image cache

I'm receiving an error with the image cache and couldn't see a resolution in the readme.

I have /app/storage/cache set to 777 and there are new files and folders created.

It works on my local Windows machine but not on the CentOS server.

Exception
There was an error with the image cache
open: /home/appfolder/vendor/kevbaldwyn/image/src/KevBaldwyn/Image/Image.php
if($cacheData) {

        // using cache
        if (($string = $cacheData['data']) && ($mimetype = $cacheData['mime'])) {
            header('Content-Type: '.$mimetype);
            die($string);
        }else{
            throw new \Exception('There was an error with the image cache');
        }

Wrong namespace?

Wen I follow installation path for laravel 4 I see the suggestion to add in providers list 'KevBaldwyn\Image\ImageServiceProvider' but it causes error "PHP Fatal error: Class 'KevBaldwyn\Image\ImageServiceProvider' not found" after investigating ImageServiceProvider.php I found that corrct namespace of that class is 'KevBaldwyn\Image\Providers\Laravel\ImageServiceProvider' Maybe you can change the installation description? or I dont understand something or do something wrong?

multiple responsive not working

it adds multiple times responsive=true in the url witch mess up imagecow detection and only the first media query work

&transform=resizeCrop,360,200;max-width=400:resizeCrop,345,192&responsive=true;max-width=700:resizeCrop,637,200&responsive=true

it should be

&transform=resizeCrop,360,200;max-width=400:resizeCrop,345,192;max-width=700:resizeCrop,637,200&responsive=true

Missing ProviderCacher in Larvel's ServiceProvider

Hi Kevin

After composer update I got an error:

Class 'KevBaldwyn\Image\Providers\Laravel\ProviderCacher' not found

It seems you forgot to use KevBaldwyn\Image\Cache\ProviderCacher; in KevBaldwyn\Image\Providers\Laravel\ImageServiceProvider. I add that line and it works.

Best

Issue with newest ImageCow?

I'm not sure if this is affecting anyone else, but I'm having issues recently and I think it may be related to ImageCow.

I'm receiving this error. The sting being passed appears to be empty, but I can't find where it's being called in :/

Zero size image string passed

open: /home/rvwd/vendor/imagecow/imagecow/Imagecow/Libs/Imagick.php
     *
     * @return \Imagick
     */
    public static function createFromString ($string)
    {
        $imagick = new \Imagick();

        $imagick->readImageBlob($string);

        return new static($imagick);

Silently Failing

I was thinking about adding some notes to describe creating the folder for the image cache, and setting it to be writable. The library silently fails (no exceptions) when the folder is not writable, and all you get is a broken link on the page.

images not displaying: URI problem

Hi,
Here's the weird thing:
Let's say I use this in one of my views:

<img src="{{ Image::path('/img/carousels/visual.jpg', 'resize', 100) }}" />

It's rendered in my browser as

<img src="/_img?img=/img/carousels/visual.jpg&transform=resize,100" />

The thing is, it's a broken image because it's looking for this URL

http://localhost/_img?img=/img/carousels/visual.jpg&transform=resize,100

But if I try this URL http://localhost/laravel/public/_img?img=/img/carousels/visual.jpg&transform=resize,100, it's working just fine, I can see the image resized.

I don't know why the url is not rendered properly. Anyway, I can't make the package work. Any help is appreciated, thanks in advance!

lifetime unit?

Hi,
I see that it's possible to chose the lifetime of the cache in the config. But what is the unit of the lifetime?

Cloudflare Caching

Hi

It appears that any image I serve through this plugin doesn't get cached through Cloudflare, whereas my standard images will. I haven't had time to fully investigate this, perhaps an issue with the URL or headers?

Use base_path

In the code there are these comments...

// is there ant merit in this being base_path()?
// if it was base_path() then any image on the filesystem could be served - is this actually desirable?

I suggest it would make sense to change this, as normally you'd want to be processing images which have been uploaded - and you wouldn't want to be uploading to the public folder.

provider unknown variable

provider unknown variable

images/provider/Laravel/ImageServiceProvider.php

private function registerImageFileSaveHandler()
{
$app = $this->app;
$this->app->bind('kevbaldwyn.image.saveHandler', function() use ($app) {
//return new S3Handler();
return new FileSystem($provider, '');
});
}

Conflict with Intervention/image

This rarely happen in production we use two image manipulation library at same time, but when developing we will check one compare another library and I found that this library not working when we have library from https://github.com/Intervention/image enabled in providers.

route
Route::get('ok', function(){
    // ImageSrc aliases for kevbaldwyn/image
    return ImageSrc::path('image.jpg', 'resizeCrop', 400, 200);
});
result with Intervention/image enabled
?=image.jpg&=resizeCrop,400,200
result without
/_img?img=image.jpg&transform=resizeCrop,400,200

It's would be nice, if this can be fixed.

Make available on Laravel 4.1

Just came across this package and it looks great. However, I'm unable to install it as it requires Laravel 4.0.x. Could it be updated to allow for Laravel 4.1.x also?

Compression quality?

Hi,
Is it possible to set image quality specifically and not as a global setting?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.