Comments (10)
FelipeEspinozaMe
commented on July 30, 2024
1
i'm actually using the mim file, i guess that the custom control loads when the builder loads, so when i group them it loads them again (its my theory), right now i got it to work this way
if (window.jQuery) {
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(mutation) {
if (mutation.addedNodes.length) {
mutation.addedNodes.forEach(function(node) {
if (node.nodeType === Node.ELEMENT_NODE) {
var frmbControl = $('.frmb-control');
var $node = $(node);
var $liElements = $node.find('li');
var groupElement = $('<li class="bg-primary text-white no-formbuilder" style="pointer-events: none;" draggable="false"><span><i class="control-icon" style="pointer-events: auto;">≡</i>Bitacora</span></li>');
//insert your groupElement
$liElements.each(function() {
var $li = $(this);
if ([ 'customControlname1', 'customControlname2', 'customControlname3' ]
.includes($li.data('type'))) {
if (frmbControl.length) {
$li.data('type')==='customControlname1'? groupElement.insertBefore($li) : null;
$li.hide();
groupElement.on('click', function(event) {
$li.toggle();
});
observer.disconnect();
}
}
//rest of code
})
}
});
});
observer.observe(document, { childList: true, subtree: true });
}from formbuilder.
lucasnetau
commented on July 30, 2024
Hi @FelipeEspinozaMe , currently there is no option to group controls. It's a interesting enhancement.
In terms of your problem. I'm not sure why the control is being inserted twice. Are you able to set a breakpoint on the function processControl in formBuilder.js and get the stack trace for when it is called twice. That way we can see which handler or handlers are firing.
from formbuilder.
kevinchappell
commented on July 30, 2024
I'm not sure of that exact problem but looks like youre making good progress. I would recommend working with the source files though, the minified files are difficult to read. formBuilding has something like control groups in the inputSets option but the UI isn't nearly as nice as your's.
In the dev demo, "User Details" and "User Agreement" are examples of control groups
Check out the inputSets option for more details.
from formbuilder.
FelipeEspinozaMe
commented on July 30, 2024
i would love to, but i dont know how to import the source code in my project i tried to import it in my laravel project but it doesnt work as intender, any tip?
from formbuilder.
rajindersinghugw
commented on July 30, 2024
Hi Team,
I need group control feature that i will add in my panel. I can add custom element in inputsets and show them in panel but i want to created group dynamically from panel.
Please guide me for the same so i will complete this point soon.
Waiting for your response soon.
Thank you
from formbuilder.
lucasnetau
commented on July 30, 2024
I had some time to look at this. The reason for the double click is the click handler for adding a control is being triggered twice, once for the control and once for the group.
This patch solves that issue
diff --git a/src/js/form-builder.js b/src/js/form-builder.js
index 1761fdf..0af1f0f 100644
--- a/src/js/form-builder.js
+++ b/src/js/form-builder.js
@@ -248,7 +248,7 @@ function FormBuilder(opts, element, $) {
$(element).replaceWith($editorWrap)
}
- $(d.controls).on('click', 'li', ({ target }) => {
+ $(d.controls).on('click', 'li.input-control', ({ target }) => {
//Remove initial placeholder if simply clicking to add field into blank stage
if (h.stageIsEmpty()) {
$stage.find(tmpRowPlaceholderClassSelector).eq(0).remove()I'll raise a PR for this patch, it makes sense to be more specific with our selector.
@kevinchappell we could also stop propagation of the click event when we handle it here.
With two small changes to your code in the original report:
Remove input-control from the group class list, otherwise the click handler will fire twice.
var groupElement = $('<li class="input-control-group ui-sortable-handle"><span><span class="control-icon">≡</span>Mi Grupo Personalizado</span></li>');Don't collapse the group when clicking on an input-control (UX improvement)
// Añade un evento de clic al elemento de agrupación
groupElement.off('click').on('click', function({target}) {
if ($(target).closest('li.input-control').length === 0) {
console.log('Click event triggered');
// Muestra u oculta los elementos de control personalizado cuando se hace clic en el elemento de agrupación
customControls.toggle();
}
});I also needed to move this flag var customControlsAdded = false; to outside the observer definition otherwise it trigger an infinite loop on Chrome.
from formbuilder.
lucasnetau
commented on July 30, 2024
Try this version of form-builder with the patch applied
from formbuilder.
FelipeEspinozaMe
commented on July 30, 2024
I managed to get it working for n custom controls and show them in an order it works like a charm with the patch provided
here is the final result if someone wants to implement it:
$(document).ready(function(){
if (window.jQuery) {
var customControlsAdded = false;
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(mutation) {
// Comprueba si se han añadido nodos
if (mutation.addedNodes.length) {
var frmbControl = $('.frmb-control');
if (frmbControl.length) {
var groupNames = ['your_group1', 'your_group2']; //Name of the groups
var customControlTypes = [ //Name of the customControl
['custom_control_type1_1','custom_control_type1_2'],
['custom_control_type2_1','custom_control_type2_2'],
];
var groupElements = [];
groupNames.forEach(function(groupName, index) {
var groupElement = $('<li class=" input-control-group ui-sortable-handle"><span><span class="control-icon">≡</span>' + groupName + '</span></li>');
frmbControl.append(groupElement);
groupElements.push(groupElement);
var customControls = $('li').filter(function() {
return customControlTypes[index].includes($(this).data('type'));
});
groupElement.children('span').off('click').on('click', function() {
customControls.toggle();
});
customControls.hide();
var firstCustomControl = customControls.first();
groupElement.insertBefore(firstCustomControl);
if (customControls.length) {
customControls.appendTo(groupElement);
customControlsAdded = true;
observer.disconnect();
}
});
}
}
});
});
observer.observe(document, { childList: true, subtree: true });
}
})
`
still i got a question, is there a way to disable the draggable for the specific li? i tried something like this
$(".no-formbuilder").draggable({ disabled: true });
but without success i can drag and drop it this way witch is kind of funny actually because it works.
from formbuilder.
lucasnetau
commented on July 30, 2024
Will need to exclude anything that is not li.input-control (https://jqueryui.com/sortable/#items). I'll take that into account when I write the PR
from formbuilder.
github-actions
commented on July 30, 2024
🎉 This issue has been resolved in version 3.19.10 🎉
The release is available on:
Your semantic-release bot 📦🚀
from formbuilder.
Related Issues (20)
- Text Area Component allows input of negative value in the Rows field HOT 2
- When Select component only has x2 options a non-functioning Remove Element button is still present HOT 1
- Can I provide custom order(alphabetical) to the fields? HOT 6
- How to custom label header ? HOT 2
- Adding field type button - Label not set HOT 2
- Vue 2: Uncaught TypeError: $(...).formBuilder is not a function HOT 9
- form-builder.js clears inputted data for tinymce fields when editing the field's options
- Required Checkbox Group - Other with text box - not validating blank value
- Form builder questions - Issue with data are not saving while edit/update the form builder questions HOT 4
- BeforeRemove event HOT 2
- How to keep the default class as className. HOT 1
- How to scroll to edit panels when opening them? HOT 5
- How to create a checkbox group with monetry value to each checkbox. HOT 2
- How to make bootstrap classes not disappear when removing a field from a row and putting it in an empty place HOT 8
- Strings set in a custom control that use custom lang file show as undefined when first rendered but work on second render HOT 9
- Labels for fields and replaceFields options do not use localized strings HOT 4
- Form render error with custom controls HOT 4
- npm plugin system HOT 1
- How to custom multiple input in one field and set the JSON output is array or object? HOT 2
- When Double-click trumbowyg area will open the Edit issue HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from formbuilder.