kevintyrrell / fishingbot Goto Github PK

The description says 'run fishingbot.jar', but pack consists of none.
Have you by accident deleted the program?

A timer for fishing would be very useful so you don't have to change it every time. you could set a duration of 34 min let's say and when 34min is up, it would stop. Bonus points for having a countdown on the main window and fuzzy length option to appear less bot-like. For example fish for 30min +/- 6 would fish for around a half hour, but would pick a length between 24-36min when you hit start.

not sure why but all of a suddenly my fishbot stopped pressing keys to cast or deploy bobber,
Any Ideas?

Please add fields to manually fill in the commands.

sry. google-translate

Hi! Thanks for this fishing bot. I am able to get it to work great for fishing but not for lures.

When it tries to apply a lure I see the icon for my fishing pole hover out onto the screen. Like what would happen if I click on the pole and was in the process of dragging it to an action bar. The lure is then never applied.

I am playing vanilla, on a Mac.

Exception in thread "Thread-5" java.lang.ArrayIndexOutOfBoundsException: Coordinate out of bounds!
at sun.awt.image.IntegerInterleavedRaster.getDataElements(Unknown Source)
at java.awt.image.BufferedImage.getRGB(Unknown Source)
at model.Angler.calibrate(Angler.java:229)
at controller.Controller.lambda$calibrate$0(Controller.java:80)
at java.lang.Thread.run(Unknown Source)

Running 2.0.1

I start calibration and then no cast happens. Timer counts down from 5 and then the crash occurs. I tried changing my resolution and disabled the hardware cursor as suggested in another thread but still didn't get the cast.

Noticed you're overhauling the whole program right now so maybe I'll just wait. I started my own version of a fishing bot awhile ago. It wasn't as far along as this one but followed the same basic concept, apart from using system sound to detect the 'splash', although your method is much more portable.

I've been reviewing the debug values when my cursor identifies the bobber (which it doesn't always do). It seems as if the "scanned value" dips to a lower than average number when the bobber animates. I've played around extensively (albeit haphazardly) with both the sensitivity settings in the JAR, as well as the graphics settings in WoW. This testing is being performed on patch 7.3.5 at Margoss's pool in Dalaran.

Perhaps there is a way that the user could input a target threshold as opposed to a calculated value?

Intellij seems to not like the AWT Clipboard. During runtime, the following exception is thrown.

Exception "java.lang.ClassNotFoundException: com/intellij/codeInsight/editorActions/FoldingData"while constructing DataFlavor for: application/x-java-jvm-local-objectref; class=com.intellij.codeInsight.editorActions.FoldingData

Based on some quick research it seems like this is not easily fixable without switching my SDK to an Intellij version? Not sure, low priority bug.

Sources: processing/processing#3870

The gold ? used as a settings toggle sometimes is mistaken for the fishing bobber if you have keep on top enabled. I suggest a different color.

PLEASE change the name of the window ... the Wow client scans your processes and search bot software. The Name ist very showy :D (sry for my bad englisch ^^)

Hi, today I updated my JAVA version on MAC OS X 10.15.6 to Java 8.271 and from now i can't calibrate my system. I run the fishing bot now for many years!

I make it the way i ever made it but every try there is the Info "Calibration failed. Unable to locate your Fishing Bobber tooltip." can I recover my old preferences? Where usually the file "FishingBot_Saved_Data" is located? And do I need the Add-on SuperMacro? it is listeted as "out of date" since last wow update!?

What can I do? THX for help kreiskrapp

It can't find the bobber, manual calibration doesn't help, and auto calibrate counts down to 1 then stops and does nothing.

Hello, do you plan to keep this under active development ? There is no other FOSS tool that does this and it would be great if we had something like this actively developed. It has a lot of potential. Just my 2 cents.

I'm not too familiar with java but I wanted to add a reset for the mouse after looting. How do you build the jar from src? What dependencies are required?

Thanks!

Wondering is this works for classic

i can not find the .jar file in the folder that was downloaded

the client puts up a dialog saying macros are not allowed to do that. using the fishing buddy addon and an option to double click the screen (or however the user sets up casting in fighbuddy) would allow lures to be applied by that addon.

I can't seem to find model.Tools

Hey, thanks for this fishingbot, it works very well except for one simple issue. It's failing on almost every other cast but I know what the problem is. So when I turn it on, the first catch always works. Then, it casts again and now if the dobber happens to land at the same spot, the tooltip appears. It then starts scanning but the tooltip is still there so the scan stops right away, thinking it found the dobber. This happens all the time, so it's pretty bad. I can work around it myself by moving the mouse away after it loots the fish. So I think it would be fixed if a line is added after looting the fish that moves the cursor away.

I'm trying to modify your code a bit, but when i try to compile it seems like tools.java is missing. Is this correct?

The command you are using to loot the bobber opens the window but doesn't loot the item.

This functionality is working fine on classic. Blizzard must have changed something.

I made a small video to better understand the issue.
https://youtu.be/6wev5b-whgE

This happens in either fullscreen, windowed (maximized), and windowed mode, with both first person camera and third person camera. After starting the bot, it doesnt cast fishing itself, and even when you manually do it fails at finding the bobber.

OS: Windows 10 home 64 bit (10.0, build #10586)

java -jar /Users/1mperec/Desktop/fishingBot/src/FishingBot.jar
Error: Could not find or load main class view.GUI
Caused by: java.lang.NoClassDefFoundError: javafx/application/Application

It works if i throw out manually, the program finds the bobber and so on.
But it does not throw out automatically. What can be the problem?

Have some type of key combo that can be used to start and stop the bot while fishing would be great, you can't really stop it while it's scanning for a lure.

Hi Kevin,

Thanks for your work, it's pretty good bot. But I think you have to do small changes to UI/logic to make bot more accurate.

1. For example bot trying to cast "/cast Fishing" so it would work only for english clients of the game cause in my case (RU) it wouldn't work. So I have to manually press "start fishing".
   Solution: just add field on program UI where user can enter macros that launch finishing. In this case you will be language independent.

2. You implement hardcoded zone where software will searching bobber, my proposal to implement customizing are. Like you did for calibration process. So user will be able to select zone where bobber would be potentially placed.

3. Randomizing - bot shouldn't use constant values at all. To make it more "human like" you have to each time randomize timings. Delay between casting fishing and etc.

4. According to catching fish, right now it's pretty hard to make it working well. Maybe would be best solution to check sound? Like it done in UltimateFishing bot written on C# ?

All of this just proposals, I don't have time now for making all this features by myself right now. Maybe later I'll do some pull requests if you are okay with it.

I've finally been able to get the cursor to find the bobber, but it immediately clicks instead of waiting for a fish. It then reports on the console that a fish was caught successfully. I've turned down the water graphics, and had the splash sensitivity set to the whole spectrum with no effect. I've also tried using different bobber toys to see if that made any difference, but it doesn't. Am I missing something?

Send /cast fishing for start casting the bobber, please add an option so we can use another text instead of /cast fishing (exemple : /cast pêche) ;)

I'm using Windows 10 latest update and Java 8 r.210, running FishingBot.jar won't do anything. No errors, won't even pop up in Task Manager for a second.

Program can't calibrate as expected. Always move mouse to wrong place.
Any suggestion?

I have a 4K Monitor and when I try to calibrate, it always fails. Even if I specify the tooltip area, have the game in focus and do everything as wanted from me, I get an Error message.

You can even see the error message in the screenshot

Just tried the latest release on 1.12.1 and after pressing the calibration button and mousing over the bobber it does not seem to calibrate. If I press start after this the program displays the message that it needs to be calibrated.

Doing a manual calibration will trigger similar behavior.

Dsnt Work the pick up and the auto cast

You should only keep the source in your respository and add the compiled jar to a tagged release here on GitHub.

Pervasive bug that I've been unable to solve so far. Stop button occasionally takes two clicks to work and sometimes resets the mouse position making it annoying to use. I believe the bug has something to do with the multi-threading.