Tests failing about gntp HOT 3 CLOSED

This seems to be somewhat related to #37 where I'm not handling my logic correctly if there is no ~/.gntp config file set.

from gntp.

Hmm, yep, that's related. At tests password is not set, passwordHash is.

UnsupportedError is raised only at _GNTPBase.set_password method.

set_password method is called twice in that test, once at setUp (self.growl.register call, it is called at GNTPRegister's constructor) and second at _notify (self.growl.notify() which calls GrowlNotifier.notify, which creates notice variable that calls GNTPNotice() constructor).

Second argument is always MD5 (default one). It's ok at register call (first one) as there are no arguments passed. At _notify however we expect that passwordHash is passed from GrowlNotifier to notice. It would be passed if password would be set but it's not.

Long story short: set_password is not called if password is not set. I bet when you run test suite password is picked from your .gntp file - if it's there passwordHash is passed correctly. I've fixed failing test at pull request #40 (simply set password so the set_password is called) but I believe that test module should be updated (see description at the pull request).

from gntp.

Thanks for the fix :)

from gntp.