kffl / pinot-client-node Goto Github PK

As of now, a single console.warn is used in one failure scenario (controller-based broker selector failing the periodically triggered update method). Additional logger invocations could be added in order to make potential debugging more convenient. On top of that, console should be replaced with a user-provided logger conforming to the standard Log4j interface (i.e. pino, winston or log4js).

Pinot supports multi-stage query engine now:
https://docs.pinot.apache.org/developers/advanced/v2-multi-stage-query-engine

As of now, controller-based broker selector attempts to update its table-to-broker mapping every 1000ms. An option to specify custom interval could be added.

Hi.

I see that in current implementation under the hood axios client is used. However since this lib is a client to DB, the performance could be critical.

There's a http client https://github.com/nodejs/undici that doesn't rely on node's http implementation which make it faster. Also it likely become a underlying implementation of fetch in future versions of node.

I see that you're passing in most cases http request function as a dependency, so maybe it worth to allow passing custom request function to connection-factory.ts functions as well? Or just replace axios with undici by default to achieve maximum performance?

The current version of the library is missing the functionality allowing for defining custom headers (i.e. basic auth) to be added to controller and broker HTTP requests.