khalidsheet / hs-m13-final-droplet Goto Github PK

Hello Khalid!

Excellent presentation and project! Really great to see you go that extra mile 🙂.

I'm going to make a list of improvements, these are just small things that you can improve for your next (android) app:

• I'm unable to sign-in with the app; I believe it's because you might have registered your app with a specific sha-1 key different than the one that I'm using (it's unique).

The error is:

com.google.android.gms.common.api.ApiException: 10: Developer console is not set up correctly.

I saw your presentation, so no worries about that. I redirected to the main screen to overcome this.

• You've got a drawable folder inside drawable; I believe this is a mistake since well... it won't work

• You've went an extra mail to have a lot of functionalities and there's one that can convince the user to install your app or not - adding a custom icon. This is really simple you just need to go New -> Image Asset and design/select your own

• Your app doesn't support dark theme, which there's no problem about it, but when you switch theme on the device the app gets broken 😅. You can easily disable this by using for instance:

AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);

or

<style name="AppTheme" parent="Theme.MaterialComponents.Light.NoActionBar">
    <item name="android:forceDarkAllowed" tools:targetApi="q">false</item>
</style>

• Android project structured migrated to .kts, so build.gradle and settings.gradle now are build.gradle.kts and setings.gradle.kts respectively.

• You can add a ";" in Kotlin or not. I noticed that on SignInActivity you're adding one. It's ignored by the compiler, but it's one less character that you need to write

• I noticed that there are a couple of imports that you didn't used; you can go Code -> Optimize imports to automatically remove all of them from the project

• Typically, a good approach when pushing code is to have only the one that's going to be used. I noticed that you've got files like the CurrentUserViewModel that you're not using or functions like the signOut that's also not used.

• You're using shared preferences and not room, so you can remove it from the dependencies section. Moreover, now room uses ksp and not kapt

• This is a bit subjective, but typically the creation of a droplet would be done using a floating action button and not a tab 😛

Once again these are just suggestions, you did an amazing work!!