khanhtrung / week02_yelp Goto Github PK

👍 Nice work. The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.

This was a challenging assignment, congrats on completing it successfully!

Grading Summary:

• Functionality: Excellent
• Code Style: Excellent
• Visual Design: Excellent
• Usability: Excellent

Overall: Excellent

Detailed Notes

• Nice work specifying the Auto Layout constraints. To rotate the simulator you can use Cmd-Left Arrow or Cmd-Right Arrow. Rotating the screen is a great way to see if you set up your constraints properly. Also try on small screen to easily screen out the autoLayout error.

• There is some small issue for layout. The name of the restaurant not fully display althought there still space.
  

Here the solution:

• Nice work linking the filter model with the controls. See this popular form library for an alternative to implementing forms manually.

• Using the asset catalog is the best practice for storing images. This also lets you keep multiple versions of each image for the necessary screen resolutions (1x, 2x, and 3x). Check out why here?

Extra comments:

• You should handle empty data search result case. Show a text in table background view such like "No Restaurant Founded"...
• Try to scroll the table view up and down for a few times and notice the restaurant name. The Label with shrink to smaller width. Try to find the solution for this.

Great job dedicating enough time to do the homework. You learned a lot! Keep up the good work.