The rust-course from kharianne

Minor feedback

rust-course/homework-03/src/operations.rs

pub mod operations {

Tohle je zbytečný, modul je definovanej už tim souborem samotnym, takhle máš crate::operations::operations :)

rust-course/homework-03/src/operations.rs

Lines 6 to 47 in 3eb15b5

 pub const AVAILABLE_OPERATIONS: [&str; 7] = [ 

 "lowercase", 

 "uppercase", 

 "no-spaces", 

 "slugify", 

 "reverse", 

 "title-case", 

 "csv", 

 ]; 

 // Defined the enum with allowed values from string modifications 

 enum StringOperation { 

 Lowercase, 

 Uppercase, 

 NoSpaces, 

 Slugify, 

 Reverse, 

 TitleCase, 

 Csv, 

 } 

 impl FromStr for StringOperation { 

 // Read the string from arg and convert it to the enum 

 type Err = String; 

 fn from_str(s: &str) -> Result<Self, Self::Err> { 

 match s { 

 "uppercase" => Ok(StringOperation::Uppercase), 

 "lowercase" => Ok(StringOperation::Lowercase), 

 "reverse" => Ok(StringOperation::Reverse), 

 "no-spaces" => Ok(StringOperation::NoSpaces), 

 "slugify" => Ok(StringOperation::Slugify), 

 "title-case" => Ok(StringOperation::TitleCase), 

 "csv" => Ok(StringOperation::Csv), 

 _ => Err(format!( 

 "Unknown modification: {s}\nAvailable modifications: {mods}", 

 s = s, 

 mods = AVAILABLE_OPERATIONS.join(", ") 

 )), 

 } 

 } 

 }

Pro zajímavost, ještě jsme si to neukazovali, ale tohle lepidlo dokáže vygenerovat crate zvanej strum

Jinak pěkný, pusť si na tom cargo clippy na drobnosti jako zbytečný returny a podobně

Minor feedback

rust-course/homework-01/src/main.rs

Lines 6 to 19 in 2d1099c

 loop { 

 println!("Enter your name: "); 

 io::stdin() 

 .read_line(&mut input) 

 .expect("Failed to read user input"); 

 if input.trim().is_empty() { 

 println!("Please enter some name..."); 

 continue; 

 } else { 

 println!("Hello, {}! Nice to meet you!", input.trim()); 

 break; 

 } 

 } 

 }

Very good, you could also try using loop as an expression and break with a name when the user finally gives it to you

kharianne / rust-course Goto Github PK

rust-course's People

Contributors

Watchers

rust-course's Issues

Minor feedback

Minor feedback

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	pub const AVAILABLE_OPERATIONS: [&str; 7] = [
	"lowercase",
	"uppercase",
	"no-spaces",
	"slugify",
	"reverse",
	"title-case",
	"csv",
	];

	// Defined the enum with allowed values from string modifications
	enum StringOperation {
	Lowercase,
	Uppercase,
	NoSpaces,
	Slugify,
	Reverse,
	TitleCase,
	Csv,
	}

	impl FromStr for StringOperation {
	// Read the string from arg and convert it to the enum
	type Err = String;

	fn from_str(s: &str) -> Result<Self, Self::Err> {
	match s {
	"uppercase" => Ok(StringOperation::Uppercase),
	"lowercase" => Ok(StringOperation::Lowercase),
	"reverse" => Ok(StringOperation::Reverse),
	"no-spaces" => Ok(StringOperation::NoSpaces),
	"slugify" => Ok(StringOperation::Slugify),
	"title-case" => Ok(StringOperation::TitleCase),
	"csv" => Ok(StringOperation::Csv),
	_ => Err(format!(
	"Unknown modification: {s}\nAvailable modifications: {mods}",
	s = s,
	mods = AVAILABLE_OPERATIONS.join(", ")
	)),
	}
	}
	}

	loop {
	println!("Enter your name: ");
	io::stdin()
	.read_line(&mut input)
	.expect("Failed to read user input");
	if input.trim().is_empty() {
	println!("Please enter some name...");
	continue;
	} else {
	println!("Hello, {}! Nice to meet you!", input.trim());
	break;
	}
	}
	}