Giter VIP home page Giter VIP logo

Comments (14)

khenriks avatar khenriks commented on July 22, 2024

Hmm, sorry I didn't reply at the time. This is probably a bug in mp3fs. Specifically, this would be a problem where it's accessing memory that it shouldn't be. The bad news is that there's not a whole lot here for me to go on to try fixing it. Do you have a shorter method to reproduce it? Or perhaps, can you run mp3fs in debug mode (with -d) and try to reproduce this error, then post the last hundred or so lines of output?

from mp3fs.

bluemoehre avatar bluemoehre commented on July 22, 2024

ok, i will setup debug and let it run again.

from mp3fs.

khenriks avatar khenriks commented on July 22, 2024

When you run mp3fs with -d it outputs things to the screen rather than writing it to a file. You could redirect it like
mp3fs -d src dest > output.log 2>&1 to get it in a file.

from mp3fs.

bluemoehre avatar bluemoehre commented on July 22, 2024

Too bad there is no real error within the debug output.
It just got stucked after opening a specific file. After i excluded that one it got stucked on next file of the same album. Maybe there was kinda bug in the past with the old FLAC v1.1.2?
I'll try to reencode the album and let u know if it was the problem.

from mp3fs.

bluemoehre avatar bluemoehre commented on July 22, 2024

Ok, that was not the problem. I reencoded the files with 1.2.x, but it still failed at the same spot.

bash:

[1]- Memory access error nohup mp3fs -obitrate=192 -oquality=5 /FLAC /FLAC2MP3/ -o allow_other,ro -d > mp3fs.log
[2]+ Exit 1 cp -r /FLAC2MP3/SINGLES/* SINGLES/

mp3fs.log:

LOOKUP /SINGLES/The Album/The Song (Extended Version).mp3
getattr /SINGLES/The Album/The Song (Extended Version).mp3
mp3fs: getattr /SINGLES/The Album/The Song (Extended Version).mp3
mp3fs: Creating transcoder object for /FLAC/SINGLES/The Album/The Song (Extended Version).flac
mp3fs: FLAC ready to initialize.
mp3fs: FLAC initialized successfully.
mp3fs: LAME ready to initialize.
mp3fs: LAME partially initialized.
mp3fs: LAME initialized.
mp3fs: Ready to write tag.
mp3fs: Tag written.
mp3fs: Finishing file. Correct size: 965, computed size: 7534889
NODEID: 742
unique: 35124, success, outsize: 144
unique: 35125, opcode: OPEN (14), nodeid: 742, insize: 48
open flags: 0x28000 /SINGLES/The Album/The Song (Extended Version).mp3
mp3fs: open /SINGLES/The Album/The Song (Extended Version).mp3
mp3fs: Creating transcoder object for /FLAC/SINGLES/The Album/The Song (Extended Version).flac
mp3fs: FLAC ready to initialize.
mp3fs: FLAC initialized successfully.
mp3fs: LAME ready to initialize.
mp3fs: LAME partially initialized.
mp3fs: LAME initialized.
mp3fs: Ready to write tag.
mp3fs: Tag written.
open[140078210910368] flags: 0x28000 /SINGLES/The Album/The Song (Extended Version).mp3
unique: 35125, success, outsize: 32
unique: 35126, opcode: READ (15), nodeid: 742, insize: 80
read[140078210910368] 65536 bytes from 0 flags: 0x28000
mp3fs: read /SINGLES/The Album/The Song (Extended Version).mp3: 65536 bytes from 0
~

kern.log:

mp3fs[21386]: segfault at 7f66937ff000 ip 0000000000402c60 sp 00007f66937f4bd0 error 6 in mp3fs[400000+5000]

from mp3fs.

khenriks avatar khenriks commented on July 22, 2024

Okay, interesting. So it looks like it's caused by this one particular file. I'd like to see first off this this bug still exists in the current master branch, and second to run mp3fs in a debugger to see where exactly the output is happening. Is there a way that you can get me a copy of the FLAC file in question? I don't want to post my email here (spam) but if you clone the repository you can get my email from the git log.

from mp3fs.

bluemoehre avatar bluemoehre commented on July 22, 2024

It seems not to be caused by a broken file. If i only copy from that album directory it is fine. But if i copy the whole SINGLES directory it fails exactly at this spot again and again. Also with the new encoded file.

from mp3fs.

khenriks avatar khenriks commented on July 22, 2024

If you copy only that one album directory, does it fail there as well?

from mp3fs.

bluemoehre avatar bluemoehre commented on July 22, 2024

nope. strange, right?

from mp3fs.

khenriks avatar khenriks commented on July 22, 2024

Ok, since I can't reproduce it, that does make things more complicated. I'd like to see if the latest code in master is affected. Do you know how to check out the code from git and compile it?

from mp3fs.

bluemoehre avatar bluemoehre commented on July 22, 2024

hm, i am not very familar with building the source. As far as i know that should have worked here:

~/mp3fs-master$ autoconf
configure.ac:7: error: possibly undefined macro: AM_INIT_AUTOMAKE
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
configure.ac:28: error: possibly undefined macro: AC_DEFINE
configure.ac:30: error: possibly undefined macro: AM_CONDITIONAL

~/mp3fs-master$ ./configure
configure: error: cannot find install-sh, install.sh, or shtool in config "."/config

from mp3fs.

khenriks avatar khenriks commented on July 22, 2024

The proper sequence for building from Git is ./autogen.sh, ./configure, make. You might get an error about building the manual if you don't have the asciidoc command installed, but you can ignore it. The mp3fs command should still build, and be present under src/.

from mp3fs.

bluemoehre avatar bluemoehre commented on July 22, 2024

Well, it seems like it is working with the today's version. It ran as long as it hits the "no space left on device".
The only errors listed are some FLAC__STREAM_DECODER_ERROR_STATUS_FRAME_CRC_MISMATCH.
(Btw is there are log which files are broken?)

from mp3fs.

khenriks avatar khenriks commented on July 22, 2024

There isn't any log of broken files per se. You can look at the messages in the debug log near that error to see which file was previously opened. You may be better off using the flac command line program to test your files. For example:

find musicdir -name '*.flac' -exec flac -s -t {} \;

should print out the flac files anywhere inside musicdir which have errors.

from mp3fs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.