khklau / turbo Goto Github PK

The mpmc_ring_queue template class currently does not have any specialisations and the default instantiation assumes value_t is not atomic so access to it is enforced via a lock. If a specialisation is provided for word size or less values, then a lock-free version of mpmc_ring_queue can be provided.

This is a prerequisite to making turbo::memory::pool lock-free.

Currently the value_size argument to turbo::memory::block is assumed to be an alignment adjusted value size. It shouldn't be relying on this assumption because the compiler won't automatically add padding for alignment since the block storage_ member variable is actually a std::array of std::uint8_t (which has no alignment requirement according to the C & C++ standard).

If the assumption is wrong values being read from the block may incur an unaligned load and hence a performance penalty on some processor architectures.

To remove the assumption an explicit alignment argument is required. Related data structures like turbo::memory::block_config will also need to be updated.