In UpdateDrawState CommandB

Reopening because <a class="user-mention notranslate" data-hovercard-type="user" data-

nevermind, the new problem is now in <a class="issue-link js-issue-link" data-error-te

Race condition in shader object layer? about vulkan-extensionlayer HOT 3 CLOSED

khronosgroup commented on July 23, 2024

Race condition in shader object layer?

from vulkan-extensionlayer.

Comments (3)

ziga-lunarg commented on July 23, 2024

You are correct, this is a bug. Thank you for reporting the issue

from vulkan-extensionlayer.

jeremyg-lunarg commented on July 23, 2024

Reopening because @qbojj wrote the following:

There's still a problem.
If a pipeline was created in another thread during locking of data for writing, that pipeline should be bound, but in current implementation VK_NULL_HANDLE is bound.

Vulkan-ExtensionLayer/layers/shader_object.cpp

Lines 2488 to 2498 in 6282367

 if (pipeline == VK_NULL_HANDLE) { 

 std::unique_lock<std::shared_mutex> lock; 

 auto& pipelines = vertex_or_mesh_shader->pipelines.GetDataForWriting(lock); 

 // Ensure that a pipeline for this state wasn't created in another thread between the read lock above and the write lock 

 if (pipelines.NumEntries() == pipeline_count || pipelines.Find(state_data_key) == pipelines.end()) { 

 pipeline = CreateGraphicsPipelineForCommandBufferState(data); 

 pipelines.Add(state_data_key, pipeline); 

 } 

 } 

 data.device_data->vtable.CmdBindPipeline(commandBuffer, VK_PIPELINE_BIND_POINT_GRAPHICS, pipeline);

from vulkan-extensionlayer.

jeremyg-lunarg commented on July 23, 2024

nevermind, the new problem is now in #282

from vulkan-extensionlayer.

Race condition in shader object layer? about vulkan-extensionlayer HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	if (pipeline == VK_NULL_HANDLE) {
	std::unique_lock<std::shared_mutex> lock;
	auto& pipelines = vertex_or_mesh_shader->pipelines.GetDataForWriting(lock);
	// Ensure that a pipeline for this state wasn't created in another thread between the read lock above and the write lock
	if (pipelines.NumEntries() == pipeline_count \|\| pipelines.Find(state_data_key) == pipelines.end()) {
	pipeline = CreateGraphicsPipelineForCommandBufferState(data);
	pipelines.Add(state_data_key, pipeline);
	}
	}

	data.device_data->vtable.CmdBindPipeline(commandBuffer, VK_PIPELINE_BIND_POINT_GRAPHICS, pipeline);