Provide move constructor and move assignment to vk::handles about vulkan-hpp HOT 5 CLOSED

That might be a good addition to the vk::handles... but they're already nothrow_move_constructible, as checked by a static_assertion in vulkan_static_assertions.hpp.

from vulkan-hpp.

Yes, but consider the following:

I have a Swapchain class, that contains a device and a swapchainKHR.

I want to have multiple windows, so each window require it swapchains. I will use the same device to create these swapchains.
Because of that, I will use vk::SharedDevice to store the device handle in the Swapchain class.

My swapchain class will own the swapchainKHR. Because I already have the device handle for shared ownership, I will use vk::Swapchain KHR instead of vk::UniqueSwapchainKHR, to not have an extra copy of the parent handle, as UniqueHandle does.

class Swapchain
{
public:
    Swapchain() = default;
    Swapchain(vk::SharedDevice device, ...);
    ~Swapchain() noexcept;
private:
    vk::SharedDevice m_device;
    vk::SwapchainKHR m_swapchain;
}

~Swapchain() noexcept
{
    if (m_swapchain)
    {
        assert(m_device);
        m_device->destroySwapchainKHR(m_swapchain);
    }
}

Now consider what happens if I do Swapchain(Swapchain&&) = default;

SharedHandles provide move operators. So for that it's safe.
But because std::move(vk::SwapchainKHR) is a copy operation, it will discard the previous handle and now I have a leak and possibly a double call to m_device->destroy().

Because of that I need to implement a move constructor for the Swapchain class, which does std::swap.
Would be nice If I could just do = default instead.

from vulkan-hpp.

Or this is intended to be handled this way? Should vk::Handles be treated like regular pointers?

from vulkan-hpp.

Should vk::Handles be treated like regular pointers?

Yes, vk::Handles don't own anything. Otherwise, they would not be copyable.
If you want to manage ownership, you need to do it on your own or use something like vk::UniqueHandle, vk::SharedHandle, or vk::raii::Handle.

from vulkan-hpp.

Ok, then I misunderstood. Thanks for clarifying.

from vulkan-hpp.