std::min clashes with macros in windows.h about vulkan-hpp HOT 5 CLOSED

Yes, it seems there slipped some std::min or std::max into one of the generated headers lately...
Will be fixed with #1906.

from vulkan-hpp.

You're right, defining NOMINMAX before including windows.h is the right thing to do.
Unfortunately, windows.h is a bit too aggressive here and bites every program that's using std::min or std::max.

from vulkan-hpp.

But that's a thing we cannot always control. What if one manually includes vulkan.h without NOMINMAX before vulkan.hpp? Or even worse, manually including windows.h?

from vulkan-hpp.

Idk, maybe we could do something like this?

#push_macro("min")
#undef min
...
#pop_macro("min")

from vulkan-hpp.

Was this a recent change? I'm seeing a similar build failure in our Vulkan Samples repo, which stops me from updating to a recent header version.

from vulkan-hpp.