kiathwe97 / pe Goto Github PK

When converting currency, I have no idea which foreign currency I am converting from. IF the user converts with a different foreign currency, it could lead to him spending a very large amount of money, as he thinks it is damn cheap in local currency SGD. Same can be said from local to foreign currency.

Could omit System.out as it is commonly used. This doesn't illustrate much to readers.

Repeated entry of same travel plan under "add" functionality is allowed, when instead it should be prevented. This could arise from users forgetting that they added it.

In this figure, I can't seem to understand the roles of Parser and Ui, until I read 2.2. Since they are not referred to in 2.1, you can just remove them.

November shouldn't have a 31st. Could use in built date classes to test this condition.

could incorporate handling of capitalised command words. As these are fast typists that we are dealing with, they could have left caps lock on, resulting in a very frustrating user experience.

Dependency lines (dotted lines) simply show that a class uses another class, saying that it has a many to one dependency relation from Trip to NewTripCommand doesn't make sense.

Subtraction at the decimal level is not done properly. Probably due to use of integer instead of double/float?

The warning should occur when the person inputs the spending that puts him over the budget as user may not check how much they have left by using "list /e" constantly. By the time the user checks, he might be way over his spending limit.

Again, a v1.0 feature that is not found in the app itself.

It says that I can share my trip details with friends but the app does not support that.

0 is not a negative number but trippie thinks otherwise

It claims to constantly ensure budget cannot be exceeded, but it doesn't warn users when it has been exceeded (when user keys in an exceeding spending). It only warns users IF they decide to check their expenses. Just try entering an expense like 10000 when your budget is only 1.

Planning trip online feature mentioned but it is not found.

When day -1 entered, it lists day 1 itinerary. Odd ain't it?

Logically inconsistent as I am able to add an expense for day 8 when I don't even have a day 8. Again, this is linked to a previous issue where the trip-in-subject is not shown explicitly- perhaps he was adding an expense for day 8 for another trip.

User might not know that the reading is done. Could add a confirmation that reading is done.

Upon using load trip, it says that trip is loaded. However, user (me) has no idea what I can do when it's loaded. Since it links to "add", perhaps you can add a precursor statement telling users to load the correct trip before using the add feature to prevent wrong adding.

When planning, users should also be allowed to enter end date, to ensure that they are planning correctly. This is not available to users yet.

When users use this feature, they are not reminded of what trip they are adding to. This could lead to frustrating planning procedures. Furthermore, some users may consider day 0 on their trips, which trippie doesn't allow, without it being stated that days should start at 1.

Screenshot 2020-11-13 at 16.48.49.png