Giter VIP home page Giter VIP logo

killbill-docs's Introduction

Docs

Kill Bill documentation (user guides and tutorials).

The site is built using Asciidoctor.

Edit and Syntax

The documentation is in the userguide directory.

AsciiDoc syntax: https://docs.asciidoctor.org/asciidoc/latest/syntax-quick-reference/

Development

To generate the documentation locally:

make.sh

Generated html files are in the build directory.

To run the site locally:

ruby server.rb

Prerequisites:

Deployment

To deploy the docs:

make.sh
update_gh-pages.sh

Notes:

  • The generated static pages under build/selfcontained are pushed to the gh-pages branch (not served by GitHub pages)
  • The gh-pages branch is then deployed by Cloudflare (https://docs.killbill.io/)
  • Minification of assets is handled by Cloudflare (check-in the unminified version)

killbill-docs's People

Contributors

andrenpaes avatar annabaker avatar deekant avatar devudopw avatar dlangille avatar gam-phon avatar getusha avatar jdmooney avatar karina0895 avatar kbbitsp avatar learnjavawithreshma avatar maksym-arturin avatar nekores avatar pierre avatar piyushkalasariya avatar pjvv avatar reshmabidikar avatar rjrpaz avatar rmeuthen avatar rowayda-khayri avatar sbrossie avatar sethdaugherty avatar slivas avatar squaredave avatar squaremike avatar vijay-rsystems avatar vnandwana avatar wwjbatista avatar wwjfrodriguez avatar xsalefter avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

killbill-docs's Issues

Remove and remove unneeded dependencies

We style load the following from document.html.slim:

  • https://stackpath.bootstrapcdn.com/bootstrap/4.1.1/css/bootstrap.min.css
  • https://cdn.staticaly.com/gh/afeld/bootstrap-toc/v1.0.0/dist/bootstrap-toc.min.css
  • https://stackpath.bootstrapcdn.com/bootstrap/4.1.1/js/bootstrap.min.js
  • https://cdn.staticaly.com/gh/afeld/bootstrap-toc/v1.0.0/dist/bootstrap-toc.min.js
  • https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600&display=swap

Investigate if they are really still required, otherwise, get rid of them.

Address build warnings

asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/LoginScreen.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ChooseTenant.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/SignOut-Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Homepage-Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/killbill_logo_LARGER.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_PlusGreen.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_InvoiceGen.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_DownArrow.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_UpArrow.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_Tag.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_Plug.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_Addon.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_CreditCard.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_Gears.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_Refresh.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/GridSample.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/PaginationControls.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ShowSortArrowsOnColumn.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ShowSortByColumn.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ClickToViewDetail.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ShowTopSearch.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ShowSearchHomepage.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ShowAdvancedSearch.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/AdvancedSearchPopup.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/AdvSearch-ObjectTypeDropdown.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/AdvancedSearchSyntax-Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/AccountPage_Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Account-Submenu.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/CreateNewAccount-Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/AddNewAccount.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Account_UpdateScreen.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_GrayDownArrow.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/PersonalInformation.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_PlusGreen.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/AddNewEmail.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/NewContactEmail.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_GrayDownArrow.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_RedX.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/CloseAccountPopup.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/AccountSubmenu-Closed.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/AccountInfo-Section-Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Account-TagDropdown.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_PlusGreen.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Account-ParentField-Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/LinkToParentPopup.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Account-ParentID-Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_GrayDownArrow.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/PaymentMethod-Expanded.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_StarClear.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/PaymentMethodStar-Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_StarFilled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/PaymentMethods-PlusSign-Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/AddPaymentMethodScreen.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/PaymentMethodStar-Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_GrayDownArrow.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Payment_Method-Transactions.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ProcessTransaction.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/TransactionKey-Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_RedX.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Invoices.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Invoice_Detail.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Invoice_Detail.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Invoice_MakePayment.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Invoice_ProcessPayment.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Invoice_Detail2.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_Tag.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Invoice_WriteOffDropdown.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Invoice_Detail3.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Invoice_VoidDropdown.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/PayAllInvoices.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Invoice-DryRunBox.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/Invoice-NextBillDate.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/i_InvoiceGen.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/AddCredit-Labeled.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/AddNewChargePopup.png
asciidoctor: WARNING: plan_alignment.adoc: line 29: section title out of sequence: expected level 2, got level 3
asciidoctor: WARNING: plan_alignment.adoc: line 39: section title out of sequence: expected level 2, got level 3
asciidoctor: WARNING: plan_alignment.adoc: line 48: section title out of sequence: expected level 2, got level 3
asciidoctor: WARNING: plan_alignment.adoc: line 57: section title out of sequence: expected level 2, got level 3
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ecs-cluster.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ecs-cluster-fargate.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ecs-cluster-name.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ecs-cluster-success.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ecs-task-definition-fargate.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ecs-run-task-config.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/ecs-run-task-security-group.png
asciidoctor: WARNING: plugin_development.adoc: line 208: list item index: expected 1, got 3
asciidoctor: WARNING: plugin_development.adoc: line 214: list item index: expected 1, got 4
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/metrics-kb-admin.png
asciidoctor: WARNING: image to embed not found or not readable: /home/runner/work/killbill-docs/killbill-docs/userguide/assets/metrics-datadog-install.png
asciidoctor: WARNING: using-https.adoc: line 112: section title out of sequence: expected level 2, got level 3
asciidoctor: WARNING: using-https.adoc: line 116: section title out of sequence: expected level 2, got level 3
asciidoctor: WARNING: using-https.adoc: line 143: section title out of sequence: expected level 2, got level 3
asciidoctor: WARNING: using-https.adoc: line 151: section title out of sequence: expected level 2, got level 3
asciidoctor: WARNING: using-https.adoc: line 166: section title out of sequence: expected level 2, got level 3
asciidoctor: WARNING: deploy_to_kubernetes.adoc: line 244: section title out of sequence: expected level 2, got level 3
asciidoctor: WARNING: deploy_to_kubernetes.adoc: line 251: section title out of sequence: expected level 2, got level 3
asciidoctor: WARNING: invoice_templates.adoc: line 140: list item index: expected a, got b
asciidoctor: WARNING: invoice_templates.adoc: line 156: list item index: expected a, got c
asciidoctor: WARNING: invoice_templates.adoc: line 161: list item index: expected 1, got 2
asciidoctor: WARNING: invoice_templates.adoc: line 194: list item index: expected a, got b
asciidoctor: WARNING: invoice_templates.adoc: line 210: list item index: expected a, got c
asciidoctor: WARNING: invoice_templates.adoc: line 218: list item index: expected 1, got 3
asciidoctor: WARNING: invoice_templates.adoc: line 229: list item index: expected a, got b
asciidoctor: WARNING: invoice_templates.adoc: line 245: list item index: expected a, got c
asciidoctor: WARNING: invoice_templates.adoc: line 250: list item index: expected 1, got 4
asciidoctor: WARNING: invoice_templates.adoc: line 267: list item index: expected a, got b
asciidoctor: WARNING: userguide_deployment.adoc: line 70: section title out of sequence: expected level 2, got level 3
asciidoctor: WARNING: userguide_deployment.adoc: line 74: section title out of sequence: expected level 2, got level 3

e-commerce website integration guide

  • Subscription billing
    • List available plans with prices (in Java and Ruby)
    • Account and payment method creation APIs (in Java and Ruby)
    • Combo subscription with add-ons API (in Java and Ruby)
    • Display next invoice date and amount (in Java and Ruby)
    • Subscription cancellation API (in Java and Ruby)
    • Entitlement enforcement API (in Java and Ruby)
  • One-off items checkout
    • Combo payment API (in Java and Ruby)

Database Migrations DDL link out of date

The database migrations guide (userguide/tutorials/database_migrations.adoc) has a link for the "latest" ddl file, along with a link to the http://killbill.io/downloads/ page. Both of these sources contain the DDL file for Kill Bill version 0.18, which is out of date. (the whole downloads page is for version 0.18, but that's a separate issue)

Might be best to just point to the github source (which is actually the first result if you google "kill bill ddl") to avoid needing to update it for each release.

Missing Public IP Info In Setup Multi-Tier System Docs

https://docs.killbill.io/latest/how-to-set-up-a-multi-tier-system.html

After

The next page will give you several options for the launch method. Choose Launch through EC2.

, I think we need to make sure that user select/edit "Network Settings" in AWS Launch Form section and set "Auto-assign public IP" option.

Also, I think we can remove setup security rules section and merge with "Network Settings" above. See screenshot below.

Update: Also if possible, link in:

.... kaui schema: https://github.com/killbill/killbill-admin-ui/blob/master/db/ddl.sql

is not pointing to raw SQL file. I think it is better to poining directly to https://raw.githubusercontent.com/killbill/killbill-admin-ui/master/db/ddl.sql

Invoice and payment relationships guide

Go over:

  • Pure payment APIs use-cases
  • Pure invoice APIs use-cases (external charges, credits, ...)
  • Relationship between
    • Invoices and Payment
    • Subscription and Invoices

Developing a Payment Control Plugin guide

  • PaymentControlPluginApi overview
  • Overview of some of the use-cases:
    • Payment routing
    • Payments pre-processing
  • Invocation and pipelining using JAX-RS and the clients

Algolia pagination

We currently only return the first 5 results. We should instead allow the user to go through the pages of results.

Generate left/right navigation

Goal: always keep the top navigation (from the index.html page) on the left, while displaying the in-page navigation on the right (similar to https://docs.asciidoctor.org/asciidoc/latest/).

A prototype has been done in the new-nav-prototype branch.

Notes:

  • The main navigation is now in html5/_main_toc.html.slim
  • In order to share the main navigation, the index.html has been converted to userguide/index/index.adoc, so that it is now generated like other files

This is what this currently looks like. Some obvious CSS work is still needed to prettify it:

Getting Started

image

Index.html

image

CSS iteration

Developing a Payment Plugin guide

  • PaymentPluginApi overview
  • PaymentPluginStatus states overview
  • ActiveMerchant plugin generation

While some of it is somewhat already covered in the main Payment guide, this guide should be tailored to plugin interactions with the gateways.

New docs site: Width of left nav bar adjustable

Wondering if we should make the width of the left navigation bar adjustable? Currently, it displays as follows for me:

image

I think it would be good to have the option to make the left navigation bar narrower so the main page content has a larger area for display.

```suggestion

    ```suggestion

Payment plugins integrate Kill Bill with a specific https://docs.killbill.io/latest/Kill-Bill-Glossary.html#payment_gateway[gateway] (i.e., payment processor), such as Stripe or Braintree. We already have many open-source payment plugins available on GitHub as listed in our https://docs.killbill.io/latest/plugin_introduction.html#payment_gateways[_Plugin Introduction_] guide.


_Originally posted by @FlowWriter in https://github.com/killbill/killbill-docs/pull/413#discussion_r981584697_
      

Unclear definitions for "entitlement" and "subscription"

There's no clear definition of these concepts in the doc, and they are non-trivial for a newbie.

in http://docs.kill-bill.org/userguide.html I find a definition for entitlement:
"An Entitlement encapsulates all the information that pertains to the entitlement question" which is recursive and not very clear; and "A Subscription is a meta abstraction that encapsulates the Entitlement and adds additonal billing information." which is not very clear either (I'm not sure what a "meta abstraction" is... also note the typo "additonal")

Here's some simplier definition that I would suggest:
"An entitlement determines whether a user is allowed to use a product a product at a given time. It refers a plan (i.e. product definition, billing period definition - monthly, yearly…) as well as possibly information about start/end date of access to the product. However, entitlements don't include billing information - they don't have anything about when and how much the user will be billed: they are only about usage of the product."

"A subscription defines how the entitlement given to the account will be billed: it includes entitlement information, and adds to it billing information such as billing start date, end date"

Probably having a clear glossary / concept definition section with these definition (as well as: Bundle; Plan; and probably a few others) would help a lot.

Thanks Kevin P. for help on this :)

Invoice templating and localization tutorial

  • Invoice template example with logo, company details and custom wiring instructions footnote
  • Invoice localization example where the previous invoice is sent to a French account:
    • Invoice translated to French
    • Line items in French (catalog translation)
    • Numbers formatting ($1,499.95 becomes 1 499,95 €)

NodesInfo APIs guide

  • NodesInfoResource overview:
    • PluginInfo and NodeCommand descriptions
    • use-cases
    • multi- vs mono-node(s) commands
  • Snippets with cURL and Java/Ruby
  • Developing your own node command plugin

Libraries updates

Follow-ups on #173:

Acceptance criteria: for the task to be complete, all pages (e.g. https://docs.killbill.io/latest/getting_started.html) must have a similar CSS and existing functionality should not be broken (e.g. menus or code highlighting).

OSGI JDBC configuration property name seems wrong

Deploying my plugin, I've used the org.killbill.billing.osgi.jdbc.url system property name, but that seems to have changed somewhere in the code...

I noticed that by setting the org.killbill.billing.osgi.dao.url everything seems to work all-right!

missing information in add certificate in ACM

At the time of writing this issue, setup CNAME section in this docs need more explanation.

[1] .... The two strings labeled Name and Value should be copied to the two required entries for your CNAME. Copy these long strings carefully. Do not include any trailing periods. ....

Not all DNS manager in domain registrar should copy all those strings in ACM's CNAME name column. GoDaddy and Google Domains only need a prefix. See this so post.

[2] Your second CNAME is simpler. The Name entry will be kaui. The Value entry is the DNS name of your Load Balancer.

We need to add one or two paragraphs about the purpose of this. Maybe explain explicitly that we need 2 CNAME in our DNS Manager:

  1. For ACM validation
  2. For KAUI
  3. For Kill Bill API it self, if needed (For discussion: I'm little bit confused as well about where we should put this information. Java Client for example, need extra work -- set certificate etc. if certificate is not valid or it is just self-signed certificate).

Potentially Lead To Misleading Info in Create Listener section

Currently, in Create Listener:

.... Next you will need to click on Add Listener to create a second Listener. This listener will use port 8443

I'm not sure the purpose of this. But, if this is supposed to handle an API request (Kill Bill backend) from internet, like various Kill Bill clients, etc. I think this is won't work.

Since Kill Bill and KAUI use the same Load Balancer (and thus sharing the same Load Balancer's DNS name, like kbhp-loadbalancer-XXX.us-east-1.elb.amazonaws.com), we can't register killbill backend to domain registrar CNAME because CNAME only support <host>. We can't set <host:port>.

Furthermore, If we remove port 8443 listener above, this section in Create Target Group should be updated as well:

Next, you need to perform the same steps for the second listener. This listener will handle messages directed to the Kill Bill server ....


Solution: If the purpose of creating listener in port 8443 is to make killbill API available to internet, I think the correct action would be Creating 2nd Load Balancer, just for Kill Bill API.

Overdue system docs problem.

the overdue docs indicates that plugin-installation API is :

curl -v \
-u admin:password \
-H "Content-Type: application/json" \
-H 'X-Killbill-CreatedBy: stephane' \
-X POST \
--data-binary '{"systemCommandType":"true","nodeCommandType":"INSTALL_PLUGIN","nodeCommandProperties":[{"key":"pluginKey", "value":"payment-test"},{"key":"pluginArtifactId", "value": "payment-test-plugin"},{"key":"pluginGroupId", "value": "org.kill-bill.billing.plugin.ruby"}, {"key": "pluginType", "value": "ruby"} ]}' \
"http://127.0.0.1:8080/1.0/kb/nodesInfo"

However, the correct field name is isSystemCommandType rather systemCommandType.

And thank you for opensource such an awesome project.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.