Review to see if this can be simplified/refactored as currently quite a beasty function

in core.js

Too messy, make cleaner!

No longer used in core.js

Such as eye/hair colour, build. stuff like that

in core.js

• Add extra randomised language as per rules

• Check SRD, are any racial features are missing?

You can create a pull request template that makes it easier to describe fixes and you can connect it the issue you are working on and it.

Tutorial
Example

It can also automatically close the issue if you list that it has solved the problem in the pull request Github Docs

Add instuctions on how to run the project in the commandline

• Add variant rules in core.js

See SRD for rules

Hitpoints appear to be broken

Add additional first names and surnames to names.js

names can be generated from several online fantasy generators

I know it's simple but good for a total beginner learning forking, cloning & pull requests.

Add additional first names and surnames to names.js

Because halfelves can have a mixture of human/elf parents, perhaps adding the option for a half elf to have a human first name, elven surname or visa versa would be cool

names can be generated from several online fantasy generators

I know it's simple but good for a total beginner learning forking, cloning & pull requests.

While reviewing #47 I generated a number of character sheets to confirm the armor class scores returned correctly.

First issue i came across was a sorcerer with a dex score of 10, and the dex modifier was -1 (should be 0)

Second issue was a warlock wearing leather armor with a dex score of 12, a dex modifier of 0 (should be +1) and and a calculated armor class of 10 (should be 13)

Need to test further to find out what is causing this, is it the push request in #47 or has the bug always been present?.

Would be cool if this pulled values from the character creation to tailor the backstory. For example if the character is super strong maybe his background was in manual labour, or if he’s quite charismatic maybe he has a history of getting into tricky situations and having to talk his way out of them.

A list of SRD compliant data can be found here

.

To make the names file easier to read it might be good to put them in alphabetical order by race and add a comment to separate sections e.g:

/* DWARF */

femaleDwarfNames
maleDwarfNames
dwarfSurnames

/* HUMAN */

femaleHumanNames
maleHumanNames
humanSurnames

/* TIEFLING */

femaleTieflingNames
maleTieflingNames
TieflingSurnames

I noticed, when running the code, that a previous merge added a bug at the bottom of the name.js (around line 1415).

...
return character;
}

<<<<<<< HEAD

=======
c2d4185
exports.returnRandomName = returnRandomName;

Add command line arguement parsing so we can generate a specific class/race/sex

The idea is to propose the addition of Travis for CI with automatic tests such as JEST and maybe ESLint.

Some armor objects currently display their ArmorClass property as:

ArmorClass: "12 + DEX"

This should be changed to something like "baseArmorClass" & additionalModifier

This will make the writing of the armor class calculation fuction a lot easier

Only background provided by the SRD

CP/SP/EP/GP/PP

Add additional first names and surnames to names.js

names can be generated from several online fantasy generators

I know it's simple but good for a total beginner learning forking, cloning & pull requests.

No longer used in core.js

• add random cha/dex +1 modifier

See SRD for rules

Alignment assignment should be weighted based on race/class, at the moment it's purely random

In names.js

expand returnRandomName() to return a name suitable for the race/gender supplied as an arguement.

long strings are currently using the '' newline escape character, I have noticed this causes print issues and parse issues with online JSON readers.

Need to think of a better way to do this

Create a single page website to display randomised character

Only for variant humans at this point but nice to have if we implement leveling

in classes.js

As part of the NewCharacter() construtor in core.js

When running the program, some details about the generated character is printed to the console. This could probably be a bit beefed up a bit to assist in testing 🤷‍♂️

Add additional first names and surnames to names.js

names can be generated from several online fantasy generators

I know it's simple but good for a total beginner learning forking, cloning & pull requests.

Unit tests, what are they, how do they work, should I be using them.

Add additional first names and surnames to names.js

names can be generated from several online fantasy generators

I know it's simple but good for a total beginner learning forking, cloning & pull requests.

New functions should be commented

add STR check before adding heavy armors, if not able to meet STR requirement assign the highest AC armor they are able to wear.

Take into account class features, armor & protental feats

Some racial abilities such as 'Keen Senses' give the character proficiency in the perception skill.

Build a function that considers the characters racial abilities and adds any bonus proficiencies

In core.js

const maleFirstNames
const femaleFirstNames
const surnames
&
function returnFirstName()
function returnLastName()

are no longer used in name generation, new collections and functions have been created in names.js.

Should be removed and tested to make sure nothing breaks. :)

I know it's pretty simple but good for a total beginner learning forking, cloning & pull requests.

Would probably be easier for readability of code to have the output of NewCharacter() be more of a flat JSON object with no(or fewer) nested properties

in core.js

Simplify/refactor, function is a bit of a beast

ALSO: Add subraces based on https://dnd5e.fandom.com/wiki/Character_Details