The nci-tools from kirill888

nci-tools's People

Contributors

Stargazers

Watchers

nci-tools's Issues

Support IdentityFile option from `.ssh/config`

If user has configured identity file via .ssh/config, use that to connect, and don't just assume that ssh agent was configured properly.

Python2 support

Hi,

It seems use of nonlocal means nci-tools does not work with python2.7

Traceback (most recent call last):
  File "/Users/aidan/.local/bin/vdi", line 11, in <module>
    sys.exit(_cli())
  File "/Users/aidan/.local/lib/python2.7/site-packages/ncitools/_vdimain.py", line 240, in _cli
    cli(obj={})
  File "/Users/aidan/.local/lib/python2.7/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/Users/aidan/.local/lib/python2.7/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/Users/aidan/.local/lib/python2.7/site-packages/click/core.py", line 1063, in invoke
    Command.invoke(self, ctx)
  File "/Users/aidan/.local/lib/python2.7/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/aidan/.local/lib/python2.7/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/Users/aidan/.local/lib/python2.7/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/Users/aidan/.local/lib/python2.7/site-packages/ncitools/_vdimain.py", line 17, in cli
    from ._ssh import open_ssh
  File "/Users/aidan/.local/lib/python2.7/site-packages/ncitools/_ssh.py", line 62
    nonlocal params

I don't mind if it is python3 only, but perhaps that should be explicit? Maybe it is and I didn't notice?

If you do want it to support python2 I can put together a PR.

Thanks for the tools BTW.

Recommend Projects