kirussel / portablefstools Goto Github PK

I have proposed some changes that fixes the following:

• for msync(), uses MS_SYNC, instead of hard coding zero
• for mmap(), uses MAP_FAILED, instead of harding coding -1
• for getopt(), using -1, instead of EOF
• added "y" to the getopt string -- this is already implemented but is missing from the command line args

References

• https://fstools.macosforge.org/trac/ticket/14
• master...kirussel/misc

I generated some quick tests to make sure any changes to fsx.c don't have any unexpected results.

References

https://fstools.macosforge.org/trac/ticket/16
master...kirussel/fsxtests

I propose the addition of a new header file, fsx.h, to help port fsx.c to other platforms. My changes compile on "Darwin Kernel Version 14.0.0" and "FreeBSD 10.1-STABLE". The biggest change is moving F_NOCACHE to the header file.

My goals were:

• to keep any conditional compilation noise confined to fsx.h, instead of putting this in fsx.c
• to keep the functionality of fsx.c the same as the original
• avoid using conditional compilation to prevent parts of fsx.c code from compiling on other platforms

References:

• https://fstools.macosforge.org/trac/ticket/15
• master...kirussel/fsxh