Giter VIP home page Giter VIP logo

nfitools's Introduction

nfitools's People

Contributors

turdus avatar

Stargazers

 avatar KD avatar

Watchers

James Cloos avatar Lukas Heiland avatar fvafrcu avatar KD avatar  avatar Lisa Hülsmann avatar

Forkers

easilab rasilgon

nfitools's Issues

function evaluate()

check if function dismo:evaluate() works for all types of fitted models. Or if we need our own.

resample() vs. aggregate() in function create_species_priority_regions

Is there a special reason, why we use resample() instead of aggregate() to change the resolution of the resulting raster?

resample() uses bilinear interpolation, which is in my opinion not totally appropriate here. aggregate() offers the possibility to use different functions to calculate the new cell values.

The resulting rasters do not only differ in cell values but also in the number of assigned cells (NA vs. values; visible discrepancy for 7 km resolution).

L. 133 of /R/site_suitability.R:
species_priority <- resample(species_priority, raster(ext=extent(species_priority), resolution=resolution))
why not
species_priority <- aggregate(species_priority, fact=7, fun=mean)?

I produced two example plots (Picea abies).
aggregate:
species_priority_aggregate
resample:
species_priority_resample

Add function calculate_weights()

... depending on sampling density as a simply way to consider differences in sampling design.
Consider additionally Germany nested design

Standardization of argument names in functions

Could you please check commit fe7f182.
Was it correct to change growth_data to gdata in function create_basal_area_data?

Could you also please check function create_species_priority_regions:
argument names in () do not match names in {}:
create_species_priority_regions <- function(basal_area_data, species="Picea_abies", hti_change, resolution=7000, negative_only=FALSE){
...
badata_species <- badata[badata$species==species,]
...
}
Do we use basal_area_data or badata?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.