kittycad / diff-viewer-extension Goto Github PK

Somehow just realized this. Was opening an old repo of mine that I created for Shortline, containing demo edits on parts through commits and PRs to demo the additions/deletions view. Turns out I didn't noticed that the current before/after view is flipped, "before" is on the right (green), and "after" is on the left (red)

Will fix asap

In the description for the extension and maybe it extension settings somewhere

where ever might make most sense

was going to show @jgomez720 an example of creating a file conversion then polling api_calls.get_async_operation to get the output but couldnt find that code which lead to my curiousity of what we are doing here for large file conversions?

Right now it's either user.image or a kittycad logo. Seems like would be pretty straightforward to add the same fallback avatar generation based on email here as well.

From KittyCAD/website/components/HeaderAccountMenu.tsx:

import { createAvatar } from '@dicebear/avatars'
import * as avatarStyles from '@dicebear/avatars-bottts-sprites'

then

        user?.image ||
            createAvatar(avatarStyles, {
                seed: user?.email || 'some-seed',
                dataUri: true,
            })

I'm seen multiple errors in the console, including having the right API files but the content script not being able to find elements on page (timing issue?)

A refresh typically fixes it

At least two improvements:

1. Use a React portal for Loading and CadDiff elements
2. Start all GetFileDiff promises at once, instead of awaiting each one (~parallel download & conversion)

https://discourse.threejs.org/t/updates-to-lighting-in-three-js-r155/53733

When upgrading to r160 the colors changed to this:
a4003d5

Reverting to r154 fixed it, very likely linked to the lighting changes.

Even if pan is disabled for now, it's still possible for the user to loose the part. Would be nice to add a Reset View button as soon as the view is altered

Seems like a pretty low hanging fruit to inject a simple three viewer at https://github.com/KittyCAD/litterbox/blob/4ddf899550addf41d6bf1b790ce79e46501411b3/samples/file_center_of_mass/output.obj for instance

Right now only clicking on Save triggers the saving of the token. Pressing Return on the keyboard should do it too

Like https://github.com/KittyCAD/diff-viewer-extension/blob/main/package.json

Follow-up to #40

A block on the side that tells what each color corresponds to, and that can show/hide the additions/deletions/unchanged geometries

As discussed with @jessfraz today, we need to find a way to avoid having the user pay $0.50 for each file for every pull request they look at, that is in the current implementation where the diff is generated browserside everything

The user agent might be a good option

As seen with @Irev-Dev, if the user has their system theme set to dark for instance, but Github's set to light, this type of panda injection happens

Apparently create-react-app is very much unmaintained by Meta now.

Heard about https://vitejs.dev/

We could also just eject and manually maintain the tools

Sorry this title sucks, but for example this KittyCAD/diff-samples@fd9eec7

it took a bit for the renders to load but seemed like it wasn't working at first. I dont know if its like a mini loader in the corner of the file or something. Maybe some way to let the user know: "we are thinking on this and working"

Links like https://github.com/KittyCAD/diff-samples/blob/1dc0d43a94dba95279fcfc112bb5dd4dfaac01ae/models/box.step may take a refresh before the extension kicks in

Would require one click before taking the snapshot

Includes tests and better threejs autocentering, cameras, etc.

Need to look more into https://github.com/KittyCAD/website/blob/main/components/Litterbox/Viewer3D/Model.tsx

As discussed in the original ticket https://github.com/KittyCAD/furrture-planning/issues/73, we need to make the current side-to-side diff evolve into some kind of more useful visualization

Some photos in that thread:

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release

and a dedicated github action like https://github.com/marketplace/actions/publish-chrome-extension-to-chrome-web-store

Right now there's a little paragraph repeated in two places that is needed at a third one, need to turn this into a nice component

Also includes vitest and likely other upgrades.

Initial attempt at #495 before closing f9095dc, got vite build to work but not vitest

That type of link https://github.com/KittyCAD/diff-samples/pull/2/commits/1dc0d43a94dba95279fcfc112bb5dd4dfaac01ae

Because it's not a URL that is listened for in

https://github.com/KittyCAD/diff-viewer-extension/blob/main/src/chrome/web.ts#L11-L24

Likely due to the use of beforeGeometry instead of a combination of beforeGeometry and afterGeometry, see

Just like for markdown files natively

Talked to @alteous, could be a coordinate system error.

When you perform a file conversion, the JSON object in the HTTP response has an output field. This field is now deprecated and has been replaced with the outputs field. As the name implies, outputs can hold multiple output files. This is helpful because if the client sends many files to convert, the server can respond with all those files :)

I really want to remove this deprecated field from the server, but we can't do that until the diff viewer extension stops using it.

Already tried this and couldn't find a straightforward solution. For some parts the Combined mode can take a minute to load.

Suspense and some if checks didn't work, need to continue to investigate

Right now we don't filter out .stl files for conversion before viewing (as .stl), and the API of course refuses to convert .stl to .stl

Showing the two token inputs instead of the logged-in profiles. Closing and reopening the popup fixes it

Found in #363

Right now with #1, the injection only works with pull requests diffs, not commit diffs.

Reported by @jessfraz

Noted after #246 got in

• The original preview for STL files remains under Code, so the user switches between our view and the native preview
• Switching back to Preview from Blame doesn't trigger a reinject

Right now the two biggest problems following #98

1. main needs to be manually unprotected to let the github action commit and push the version bump
2. since the release+tag is what starts the action, the version corresponding to the tag is wrong (the commit right after the tag fixes it)

We solve both by having a bump version PR before we start the release, and remove the auto commit from the action itself

Right now .step files are detected as compatible but not .stp

Right now the tests are pointing to somewhat random changes on other repos assets here, like https://github.com/KittyCAD/kittycad.ts/pull/3/files where the .obj file is only added, not modified. My manual testing when developing often takes place on https://github.com/pierremtb/SwStpGitExample, an old repo I had created for myself 2y ago.

I think we should create a new one in the KittyCAD org, with dummy "real cad use" commits and PRs. And update the e2e tests to point to it