kittygiraudel / eleventy-plugin-footnotes Goto Github PK

Hi Kitty,

Thanks so much for this plugin!

I think it would be nice if the plugin exposed an API for adding a custom class name (or multiple class names) to any one of the individual elements that it renders, like the ol, li, or anchors. That way, it's more flexible and less opinionated out of the box.

For example, in my use case, I have a custom utility class that applies some standard styling to all lists. I want to be able to apply this class to the ol itself, but it's not currently possible to do this because the plugin strictly enforces BEM.

Here's how markdown-it-toc-done-right does things, just as an example:

.use(markdownItTocDoneRight, {
    listClass: 'list toc-list',
    itemClass: 'toc-item',
    linkClass: 'toc-link',
    listType: 'ol',
  })

The benefit of this is that you can still enforce BEM yourself while also including additional classes as needed.

Hi Kitty,

First, thank you for this component (and generally for all your works) which helped us build our own into aem env.

I would like your point of view concerning the deprecation of the doc-endnote role: https://www.w3.org/TR/dpub-aria-1.1/#doc-endnote and the recently change into Axe dequelabs/axe-core#2759

What is your recommandation about this change? Should we simply remove the role on <li> or change it for another one like doc-footnote?

Thank you for your time and your answer.

Xavier.

Hey there! I just installed your plug-in and discovered that your example code is missing a comma between the ID and the text of the footnote. It should read:

Something about {% footnoteref "css-counters", "CSS counters are, in essence, variables maintained by CSS whose values may be incremented by CSS rules to track how many times they’re used." %}CSS counters{% endfootnoteref %} that deserves a footnote explaining what they are.