[FEATURE] Record pytest fixtures about pytest-recording HOT 6 OPEN

For scope="module" it also does not record requests/responses done in fixtures.

from pytest-recording.

Hi! Unfortunately I don’t have much bandwidth to implement it myself, but will be happy to provide guidance and review a PR

from pytest-recording.

What could be done to make pytest-recording work for fixtures? I'd like to use this library for all VCR so we can ensure headers are filtered by default, but we can't currently do that if it doesn't support recording for session-scoped fixtures.

from pytest-recording.

@Stranger6667, I'd be happy to submit a PR to support marking fixtures in this library. Could you please point me in the right direction or any known blockers?

from pytest-recording.

Hi everybody! Sorry for the delay.

I think that the way to approach this is to use the logic from the _vcr.py module with fixtures of non-"function" scope. For example, make each "session" fixture depend on a separate "vcr_session" fixture that works similarly to vcr. I.e. opens a context manager that records a cassette.

Though, not sure about configuring such a cassette writer - all the cassette naming & other stuff comes either from higher-level fixtures or pytest marks. The latter don't work on fixtures as far as I can tell :( However, there are module-level marks, so it may be used for recording cassettes inside module-level fixtures.

Here is an idea: Make a session-level fixture that works similarly to the vcr one and also is autouse=True, but can only access session-level configuration (e.g. session-level vcr_config fixture). Then disable it inside the vcr fixture, so it is not recoding calls during the test.

Recording module-level fixtures adds an extra layer here but could be done similarly implementation-wise: no access to higher-level configs & disabling the session-level fixture inside.

Important note: We really need to isolate cassettes from different levels during execution. As VCR is mocking transports, I'd assume it is replacing globally-available functions, so cassettes will interfere with each other. So, it might require some bookkeeping with enabling/disabling different cassettes properly.

Those are my current thoughts on this problem, and I didn't check if this approach will actually work (I assume it should). Let me know if you'd like me to elaborate.

from pytest-recording.

Hi @Stranger6667, is there any update on this? I would be really nice to be able to use vcr in fixtures.

from pytest-recording.