kjos / xposedjitterygyrofix Goto Github PK

So it seems that recently, an update to the Google Cardboard SDK introduced its own sensor API with automatic drift correction and stuff like that. For VR apps, it's now the advised way to access the sensors, instead of the android.hardware.Sensor API.

The bug was first spotted with Cmoar Cinema Pro (not the Free, it doesn't use the Cardboard API) but it can easily be reproduced using VRTV Video Player Free: this app provides an option "Orientation Provider" with 4 choices:

1. Google Cardboard SDK (default): this produces the aforementioned bug.
2. Manual touch input: use the touch screen to move the screen instead of the sensors. It also bypasses our module but that's normal.
3. Improved Orientation Sensor: no problem, the module works.
4. Calibrated Gyroscope: no problem also.

It seems this Cardboard sensor API is quite new so I don't have much more info.

Hi,

First of all, thanks so much for providing and developing this fix! Unfortunately, it does not seem to work with emulated gyroscopes. I am on a Huawei P8 with the following gyroscope fix: https://forum.xda-developers.com/showpost.php?p=64862689&postcount=2

Have you planned to address this issue?

Thanks and all the best,

greeny18

I received this from rovo89

Dear developer(s),

I noticed that your module "Gyroscope Noise Filter" (net.kajos.gyronoisefilter) doesn't use the Xposed API correctly. The APK for version 1.6 includes the compiled classes of the Xposed API instead of just referencing them. This can cause various strange issues and won't work at all on KitKat and below.

Please check out http://api.xposed.info/using.html for instructions on using the API correctly. It should be very simple to correct your build settings and upload a fixed version, no matter whether you're using Android Studio or Eclipse. Please let me know if you have run into any issues with this switch, ideally by creating an issue on GitHub: https://github.com/rovo89/XposedBridge/issues

Since Xposed v84, users of your module should see a warning in the Xposed log. I plan to turn this into an error in one of the next versions, preventing such modules from being loaded. Therefore, I ask that you address this as soon as possible. If you don't want to maintain your module anymore, consider looking for a new maintainer, or in the worst case hiding your module from the repository.

Thanks,
rovo89

After fixing #6 the video is shown (and without jittering) in the Youtube app but now the screen is jittering in the Cardboard Camera app, Google Street View app... It seems like the module was disabled, but it is enabled.

Xposed Framework: v79 sdk22 arm
XposedJitteryGyroFix 1.6
Lollipop 5.1
Motorola Moto G 2014

When the module is enabled, any 360º video in the YouTube app in fullscreen (landscape) and in cardboard mode shows no video, only the vertical bar and the gear icon.

Tested in a Motorola Moto G (2014)

Hello,
Can you please share updated APK that you posted in this comment: [https://github.com//issues/7#issuecomment-170726380]? That link is no longer working.

I want to try other hooks, because in my case the module fails with NoSuchFieldException for sHandleToSensor field referenced in GyroscopeNoiseFilter.java at 231 (this happens on Cyanogenmod 13).

Thank you in advance!