kkarpieszuk / wc-price-history Goto Github PK

Hi there,

First of all thank you for this wonderful addon!
Secondly I have some issue and would like to know if there's a workaround.
Since I have a custom template for products, I generally just duplicate product and change the txt/pictures/price and publish it..
But it seems that the addon is picking up the initial price when the product was duplicated prior to publishing it and now when I try to put the discount price it posts the price from the initial duplicated product.
Any thoughts on how to solve this? since I don't have a blank template (the one without the pricing on it) and that wasn't published.
Thanks in advance!

Describe the solution you'd like

see here
https://wordpress.org/support/topic/minimal-price-text/#post-16930890

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

https://uokik.gov.pl/aktualnosci.php?news_id=19234

"If the users visits site and sees the info the price would be lowered after providing publicly available coupon code, that price should be taken into account when calculating the lowest price"

Polish UOKIK states it is ok to present "30-day low: USD 20 " with the line throught, so I will add such ability as an option.

https://uokik.gov.pl/aktualnosci.php?news_id=19234

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

I've just updated the file. It caused a fatal error. I received a message from Wordpress that there is a mistake in the new version of the plug. Is it going to be fixed? When?

How the project is setup:

All products on the store are variable. The variation sale price gets update only via REST API, all sales are always timed (they have start and end date set, time portion of datetime is always 00:00).
We also update the stock on a daily basis via the REST API.

The issue:

We have selected the "Day before product went on sale (excludes promotional price)", on the day of the sale this works correctly the previous day's price is shown, but the next day the minimum price becomes the current sale price.

Investigating the code:

Looking through the code (WordPress and WooCommerce are not my primary environments, so I could be off).

First the condition $timestamp >= ( $sale_start_timestamp - ( $days * DAY_IN_SECONDS ) ) && $timestamp <= $sale_start_timestamp located in HistoryStorage::get_minimal_from_sale_start also includes history data of the day the sale started.

And this might be an issue because of ProductUpdates::update_price_history that gets triggered on woocommerce_save_product_variation hook. I assume this hook also gets triggered when we update the variation stock? If that is the case the price history will contain the reduced price and with that condition, which I mentioned before, it will pick it up when displaying the lowest price.

Polish UOKIK issued statement "the lowest price in last 30 days" should NOT include promotional price.

https://uokik.gov.pl/aktualnosci.php?news_id=19234

So if the user choose "For products being on sale, count minimal price from: > Day when product went on sale " it should ignore the lowest price from the day when it went on sale.

Maybe I will add third option "Day before product went on sale" and add explanation it is UOKIK recomendation.

From here

https://wordpress.org/support/topic/does-not-work-for-variable-products-on-woocommerce-6-3/#post-17343648

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

with attribute for product id

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

reported here https://wordpress.org/support/topic/does-not-show-the-price-properly/

I've noticed that the lowest price (using the shortcode) is displayed without tax, despite the following WooCommerce tax settings:
"Prices entered with tax" -> "No, I will enter prices exclusive of tax"
"Display prices in the shop" -> "Including tax"
"Display prices during cart and checkout" -> "Including tax"

Behavior:
The price is displayed without tax

Expected behavior:
The price is displayed with tax included

Relevant package versions:
WooCommerce 7.3.0
WC Price History 1.6.1

Expected scenario:

• go to wp-admin > woocommerce > price history
• I see each section title (like for example"Display minimal price on/for:") in red color

Reported here:

https://wordpress.org/support/topic/display-current-price-not-price-of-the-last-30-days/#post-17396239
and here
https://wordpress.org/support/topic/display-current-price-instead-of-price-from-30-days/
and here
https://wordpress.org/support/topic/minimalna-cena-przed-obnizka/

If user installs the plugin, and then changes the price by starting promotion or any other case, curently plugin will save old price and new price separated by one second.
But because there no older price entries, the settings "track prices before promotion start" does not work: there is no older price, so plugin displays promotional price as the lowest one in the last 30 days.

The fix is to check if the price change is going to be saved for the first time and if yes, save old price also with a date one day before.

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

Cases:

• allow to display it only if the product is on sale
• make possible to not display on products list pages (only on single product page)
• ...other cases (add in comment please)

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue descriptions (features with most reactions will get higher priority)

The lowest price is displayed in the format of 77,2zł instead of 77,20zł. That's with the number of decimals in the WooCommerce currency settings set to 2. The currency settings, including decimals, seem to be ignored. For the record, this is using the shortcode, but this seems like a more general bug with regards as to how prices are displayed.

Expected behavior:
The price is displayed according to WooCommerce currency settings.

Relevant package versions:
WooCommerce 7.3.0
WC Price History 1.6.4

Describe the solution you'd like

from here:
https://wordpress.org/support/topic/najnizsza-cena-nie-pojawia-sie-na-listingu/#post-17031233

product price is not displayed on divi store page because it does not meet any criteria from \PriorPrice\Prices::is_correct_place filterable

solution: add general filter to this method so site owners will be able to adjust the method result and make it displayable in custom places

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

WPML Can't find a string for the message, so cannot be used on multilingual websites :(
or maybe it can be used, but I don't know how?

Describe the solution you'd like

it should be possible to track prices for product being set on sale BEFORE plugin installation/activation

Steps to see the problem

1. user has site with products being on sale
2. user activates plugin
3. now he has to go to each product and resave it to have price tracking started
4. there should be some option like "scan products on sale and start tracking the price history"

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

Describe the solution you'd like
From here https://wordpress.org/support/topic/doesnt-seperate-product-variations/

Steps to see the problem

https://www.youtube.com/watch?v=MGI2puTPUqY

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

handle other cases than setting discount in standard Sale field.

This will require user input with the info what kind of dynamic discounts they use.

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue descriptions (features with most reactions will get higher priority)

doable only when #10 is merged

If the user activates the plugin for the first time (it will be known if we check get_option( 'wc_price_history_settings' )['first_history_scan'] is not set or the value is 0 and in wp_postmeta the is absence of any single row with meta_key = _wc_price_history ) display admin notice saying it seems to be the first activation and propose the user to scan products to start saving products price's history. The notice should not be able dismiss.

Other options for first_history_scan:
1 - in progress
2 - done

When use click the button to start the scan, redirect him to a new settings page in menu Woocommerce > Price History > First Run and start scanning products using ajax.

In the batches of ten products, check if they do not have wp_postmeta with meta_key = _wc_price_history and if not:

• save the current price in the history for the day before the plugin was installed (today)
• save the current price in the history for the day when product has been created

While scanning, display progress bar on this site. When the full scan is done display the info about the end of the process and propose user to be redirected to Woocommerce > Price History to do the plugin setup.
When the scan is started and still in progress (there are still products without wp_postmeta with meta_key = _wc_price_history), update first_history_save_done to the value of 1. When the scan is done update this settings to the value of 2.

When working with first_history_save_done setting, use PriorPrice\SettingsData

When working with product history, use PriorPrice\HistoryStorage

From here https://wordpress.org/support/topic/price-history-doesnt-show/

https://wordpress.org/support/topic/strange-behaviour-on-price-increase/

At the moment of the price change should be stored not only the price just set but also the price being unset. Without this, it does not see previous prices if they were set earlier than in x last days.

https://wordpress.org/support/topic/info-o-cenie-w-ciagu-30dni-dla-wariantow/

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

reported here https://wordpress.org/support/topic/doesnt-retrieve-the-lowest-price-before-the-sale/

steps:

• create a new products, set price to 300
• go to list of all products
• click option duplicate under the product
• open duplicated product
• set price to 500
• open duplicated product in front end
• bug: it shows the lowest price was 300

Reported here https://wordpress.org/support/topic/not-working-properly-146/

If it is set to not display minimal price on shop page, it is still displayed on products category archives pages

Possible solution:

• add setting to display minimal price on products category pages
• respect it in \Prices.php

Describe the solution you'd like
Time based price history chart

Steps to see the problem
A schortcode which would display a line chart with price history.

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

History price doesnt display when:

• price has changed (post/product has a row in wp_postmeta: _wc_price_history with any date value)
• date is older than in settings days_number

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

Hello,

first of all, thanks for the excellent work with the plugin =)

I found the issue with displaying prices when using shortcode [wc_price_history].

My settings in woo: 12,90 €
[wc_price_history] is displaying: 12.9 € -> with a dot . and without 2 decimals.

Thanks
Simon

Place the link to https://wordpress.org/support/plugin/wc-price-history/reviews/#new-post with a prompt to provide plugin review in the repository.

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

Handle taxes

reported at forum here
https://wordpress.org/support/topic/netto-brutto/#post-16355743

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

Hint: Are you waiting for the same feature to be implemented? Please react with ❤️ to this issue description (features with more reactions will get higher priority)

Reported here https://wordpress.org/support/topic/not-working-properly-146/

After the installation plugin does not show history at all because it is saved only on product update.

Possible solution:

• on minimal display, if checked that history does not exist, update it with the current price