Add support for Laravel 5.8.* about laravel-translatable-string-exporter HOT 10 CLOSED

Pull requests are always welcome, @dacoto ;)

from laravel-translatable-string-exporter.

composer.json:
"illuminate/support": "5.4.|5.5.|5.6.|5.7.|5.8.",
"illuminate/translation": "5.4.|5.5.|5.6.|5.7.|5.8.",

from laravel-translatable-string-exporter.

@dacoto Thanks. But Is there a way to test this? In other words, are you sure that the code of the package will have been compatible with Laravel 5.8 by the time of the official release?

from laravel-translatable-string-exporter.

I don't know, but laravel 5.8 comes out in a couple of months, now we have the develop branch that can be tested, there are not many changes, so I think it will be compatible.

from laravel-translatable-string-exporter.

@dacoto I appreciate your help in keeping the package up to date.
I see three options here:

1. Do nothing until Laravel 5.8 is released. It worked Okay for previous releases because I guess not many people upgrade their projects right on the day of the release.
2. Wait until I release 1.1.0 version of this package and then commit your proposed change to the master branch of the package and not release any versions until Laravel 5.8 is released. It's kind of risky because it prevents any hot fixes for this package (or at least make them difficult).
3. Create a separate branch for this change and test it with Laravel master branch.

from laravel-translatable-string-exporter.

Some updates:

1. 1.1.0 is here https://github.com/kkomelin/laravel-translatable-string-exporter/releases/tag/1.1.0
2. Laravel 5.8 releases today https://twitter.com/laravelphp/status/1100068185267679232?s=11

I think it's time to start working on the Laravel 5.8 support.

from laravel-translatable-string-exporter.

Just released 1.2.0 with Laravel 5.8 support. Please test @dacoto. Thanks

from laravel-translatable-string-exporter.

Ok, thanks.

from laravel-translatable-string-exporter.

Everything works perfectly with laravel 5.8, Thank you very much.

from laravel-translatable-string-exporter.

You're welcome, @dacoto. Thank you for reminding me about adding support for new releases of Laravel.

from laravel-translatable-string-exporter.