Giter VIP home page Giter VIP logo

Comments (13)

wilsenhc avatar wilsenhc commented on May 31, 2024 1

Are you willing to drop support for PHP 7.4 and Laravel 5.x/6.x/7.x for v2? Since they are not supported anymore.

Even Laravel 8.x has support until January 24th, 2023

from laravel-translatable-string-exporter.

wilsenhc avatar wilsenhc commented on May 31, 2024 1

There's this in the official documentation.

Version PHP (*) Release Bug Fixes Until Security Fixes Until
6 (LTS) 7.2 - 8.0 September 3rd, 2019 January 25th, 2022 September 6th, 2022
7 7.2 - 8.0 March 3rd, 2020 October 6th, 2020 March 3rd, 2021
8 7.3 - 8.1 September 8th, 2020 July 26th, 2022 January 24th, 2023
9 8.0 - 8.2 February 8th, 2022 August 8th, 2023 February 6th, 2024
10 8.1 - 8.2 February 7th, 2023 August 6th, 2024 February 4th, 2025

(*) Supported PHP versions

from laravel-translatable-string-exporter.

kkomelin avatar kkomelin commented on May 31, 2024 1

Thank you @wilsenhc for the information. I think it's safe to drop support for PHP 7 and Laravel 5-7. Will work on it in my spare time. Please let me know if you'd like to help.

from laravel-translatable-string-exporter.

wilsenhc avatar wilsenhc commented on May 31, 2024 1

@kkomelin Looks like a much better approach to just restrict the versions in the composer.json

from laravel-translatable-string-exporter.

kkomelin avatar kkomelin commented on May 31, 2024 1

For your information @wilsenhc, I decided not to change config defaults. So we should be ready for 1.18.0

from laravel-translatable-string-exporter.

kkomelin avatar kkomelin commented on May 31, 2024

Hi @wilsenhc,

That's a good question. We need to see what we would get from that action.
If not much, then better to follow the "don't break what is working" principle.

What do you think we would get if we drop support for PHP 5.6 and other previous versions?

from laravel-translatable-string-exporter.

wilsenhc avatar wilsenhc commented on May 31, 2024

The opportunity to use newer language features from PHP 8.x and having to maintain for less framework versions is a good enough reason to drop support for older versions.

from laravel-translatable-string-exporter.

kkomelin avatar kkomelin commented on May 31, 2024

The opportunity to use newer language features from PHP 8.x and having to maintain for less framework versions is a good enough reason to drop support for older versions.

@wilsenhc It's good enough reason for you maybe but from the business point of you it's not. I need some visible improvement. What will dropping support of older versions give our users? For example, speed, UX improvement, etc.

I don't support older versions, they just work because they are stable enough. Currently the maintenance takes max 1h/mo on average from me. How can you reduce it even further?

from laravel-translatable-string-exporter.

kkomelin avatar kkomelin commented on May 31, 2024

Even Laravel 8.x has support until January 24th, 2023

@wilsenhc Could you please give me a link to the Laravel release pipeline where I can see what version of PHP they support?

from laravel-translatable-string-exporter.

wilsenhc avatar wilsenhc commented on May 31, 2024

Yes, of course I'd like to help out in any way I can

from laravel-translatable-string-exporter.

kkomelin avatar kkomelin commented on May 31, 2024

That's great of you @wilsenhc. Thank you.
Would you be willing to review the Github actions in order to remove unnecessary PHP and Laravel versions from them? If so, let's move our discussion to this issue #76

from laravel-translatable-string-exporter.

kkomelin avatar kkomelin commented on May 31, 2024

I think we may not need a major version actually because we can restrict supported php/laravel versions through composer.json. It means that users on old PHP or Laravel won't be able to update the package to a newer version - composer will take care of that.

from laravel-translatable-string-exporter.

kkomelin avatar kkomelin commented on May 31, 2024

Here we go https://github.com/kkomelin/laravel-translatable-string-exporter/releases/tag/1.18.0
@wilsenhc Please test and let me know if anything goes unplanned. And thanks again for your effort!

from laravel-translatable-string-exporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.