Allow new lines in translations about laravel-translatable-string-exporter HOT 7 CLOSED

Hey @marijnkampf,

Thanks for the proposal. I like the second idea with the config option more.
But before we spend time on developing anything, let's answer a few questions:

1. We probably need a particular example where this feature is applicable. Could you please provide it?
2. Did you try "\n" control symbol to make a new line inside a translatable string?
3. What do you think about HEREDOC and NOWADOC? We're currently not supporting them.
4. Some people may still use __("translation.keys"). As I know, translation keys can't contain white spaces or new lines. Will your proposed change affect those developers' normal workflow?

Thanks.

from laravel-translatable-string-exporter.

1. I'm using Markdown in some translatable labels to allow for emphasis. So an example would be:
   __("# Hello world

Welcome to *Thunderdome*")

2. That would probably work, but would result in less readable text to translate.

3. This would require some significant changes in the regular expression used to matching strings.

4. No it won't affect keys without spaces or new lines.

from laravel-translatable-string-exporter.

@marijnkampf Thanks for your answers. Now I understand your situation better.

The simplest solution in your case is to split the line into two because they have different meaning/purpose. And, in fact, in the resulting JSON, your line break would be "\n" or "\n\n".

Also, I would encourage you to try to avoid any markup/markdown markers/tags in your translatable strings because the translator doesn't have to be familiar with the programming languages or tags. From my experience, any markup in the strings leads to not closing tags or skipping the markup completely by translators.

from laravel-translatable-string-exporter.

The simplest solution in your case is to split the line into two because they have different meaning/purpose. And, in fact, in the resulting JSON, your line break would be "\n" or "\n\n".

That would be a work around but my source code will be more readable without them.

If I create a pull request for an new-lines option are you happy to merge it?

from laravel-translatable-string-exporter.

That would be a work around but my source code will be more readable without them.

I would put big multiline text fragments into a database/files and fetch them depending on the selected language. Modern cache solutions can make such change almost not noticeable for end-user. But it's up to you.

If I create a pull request for an new-lines option are you happy to merge it?

Of course, go ahead. Just keep current user settings unchanged. And please add an automated test for it.

from laravel-translatable-string-exporter.

@marijnkampf Just released https://github.com/kkomelin/laravel-translatable-string-exporter/releases/tag/1.9.0 Please test it.

from laravel-translatable-string-exporter.

@marijnkampf Just released https://github.com/kkomelin/laravel-translatable-string-exporter/releases/tag/1.9.0 Please test it.

It's all working. Thanks!

from laravel-translatable-string-exporter.