klop / klparallaxview Goto Github PK

The current CAAnimationGroup approach is using kCAFillModeForwards alongside removedOnCompletion = NO. The result is that animations are repeatedly added to the layer without deallocating on completion. A clean fix would be to modify the - createShadow - removeShadow methods to add the animation group themselves and set the model layer's properties to the arguments passed to - groupAnimationWithShadowOffset:, rather than returning an animation group, allowing us to revert to default behaviour (removedOnCompletion == YES && fillMode == kCAFillModeRemoved).

After every iteration of the complete animation cycle, the content view's subviews' frames are shifting and changing size (slowly).

- initWithCoder: is yet to be implemented, it shouldn't be too difficult though -- using KLParallaxViewTypeTag might make sense here?

CABasicAnimation gives more finely grained control than UIView, and in fact it makes no sense that there are layer transforms going on in UIView animation blocks since they don't do anything.