kmerenkov / brukva Goto Github PK

In the yield bench demo,if I do not open the redis server, the yield never returned, I think this is not a good idea

Mixing tornado.gen and adisp doesn't appear to work in tornadoland.

_sudden_disconnect tries to access the parameter callbacks that's not currently being passed to it.

  File "x/brukva/client.py", line 336, in get
    self.execute_command('GET', callbacks, key)
  File "x/brukva/client.py", line 242, in execute_command
    self._sudden_disconnect()
  File "x/brukva/client.py", line 179, in _sudden_disconnect
    self.call_callbacks(callbacks, (ConnectionError("Socket closed on remote end"), None))
NameError: global name 'callbacks' is not defined

Tests don't actually do anything

CustomAssertionError isn't thrown when one of assertion functions fail.

Implement pipelines

Make it just as in redis-py - buffer all commands and then send all at once.

after doing curl http://localhost:8080/msg -d 'message=Hello!'

I get:

ERROR:root:Exception in callback <tornado.stack_context._StackContextWrapper object at 0x1013a0890>
Traceback (most recent call last):
File "/Library/Python/2.6/site-packages/tornado-2.0-py2.6.egg/tornado/ioloop.py", line 370, in _run_callback
callback()
File "/Library/Python/2.6/site-packages/tornado-2.0-py2.6.egg/tornado/stack_context.py", line 159, in wrapped
callback(_args, *_kwargs)
File "build/bdist.macosx-10.6-universal/egg/brukva/adisp.py", line 113, in _send_result
self.call(self.g.send(result))
File "build/bdist.macosx-10.6-universal/egg/brukva/client.py", line 946, in listen
ctx.ret_call(result)
File "build/bdist.macosx-10.6-universal/egg/brukva/client.py", line 63, in ret_call
self._call_callbacks(self.callbacks, value)
File "build/bdist.macosx-10.6-universal/egg/brukva/client.py", line 31, in _call_callbacks
callbacks(value)
File "socketserver.py", line 44, in on_message
(error, data) = result
TypeError: 'Message' object is not iterable

I noticed that there's a Pipeline class, could you provide some documentation and examples on how to use it?

att

Cover all commands

At the moment not many commands are covered. That's enough for proof of concept but complete coverage is a must.