kokernutz / traktor-kontrol-screens Goto Github PK

Hey folks,
Just got an s4mk3 and was sent here by another fan. I'm very new to QT but managed to get Camelot keys to show, but not while respecting the preference setting -- I'm guessing because of the nested if's. Is there a better way to do this?

text: deckInfo.hasKey ? (prefs.camelotKey ? utils.convertToCamelot(deckInfo.keyString) : deckInfo.keyString) : "No key"

When I take out the preference check it works fine:

yuletide@4371ff3

Edit: Thought I fixed it but not quite there. If prefs.camelotKey = false it just shows "No Key" for every track. If true then we get camelot keys
yuletide@39c540e

Request to add an indicator of whether the deck has Key Lock turned on, possibly to the Deck Header.

First, thanks for this mod, this is reviving my love of my S5! Second, I have a couple of features requests I was wondering if it would be possible to get? FWIW, I have some technical knowledge myself and wouldn't mind hacking around with this a bit, if these aren't anything you were interested in doing then perhaps you could just give me a nudge in the right direction of how to figure out how to implement any of these?

• Change the coarse BPM adjustment to less than 1 BPM, maybe 0.5 or 0.1.
• Have the individual deck filter labels actually display the effect, rather than "MFX1", "MFX2", ...
• Ability to change individual deck BPM without activating the BPM overlay (https://www.native-instruments.com/forum/threads/supreme-edition-mod-traktor-s8-screen-mapping-mod.348539/#post-1753509 seems to have this)

The key related options for the deck header Info are no longer working. I've tried 17, 18 and 31. The field stays empty. Probably caused by the new key related features?

Request to add track time column to Browser. Is it possible?

"Okay so I found a problem with the mod. If you set “Bars Per Phrase” in TP3 to zero then TP3 tracks just display Bars.Beats (no phrases, which is really handy if you’re musically trained). However if I then set phraseLength to zero in the mods Prefs.qml then the S5 shows “NaN.NaN.1” on the display. Do you think you can fix this so it properly shows bars.beats when set to zero? :)"

https://www.native-instruments.com/forum/threads/new-display-mods.323274/page-9#post-1756545

Hi

You did a great job with your programming, almost everything is working fine, but if you are in the Stepsequencerscreen the Pitch knob is not working correctly.

Best wishes Martin

When looking for other tracks to play, you can see the shape next to the tracks that are in key, but there is no color change and all are still colored in "Grey".

It opens up nicely, but browser controls do not respond anymore, with 3.3.0 all ok.
What debug info should I include?

Is there additional documentation on which of the deck header text options are which? "Key" vs "keyDisplay" vs "keyText" is not immediately apparent to me, and neither is "bpmTrack" vs "bpmStable" vs "tempo" vs "bpm" vs "tempoStable", for examble.

Hello, @JorgeHontoria :)
I recently found your fork (not committed yet, so I can't post an issue on your fork), and tested with the Kontrol S5.
I found that the key match indicator isn't working at all, and some odd visual glitches (see attached images)

https://github.com/kokernutz/traktor-kontrol-screens/assets/15059021/a1d96a71-20c7-4e17-9f51-a10ceacde24d

I was trying to figure out why it wasn't possible to map the filter to select MixerFX, turns out that because the S8 has an internal mixer it is not possible to remap the button in any way (this includes the CUE button). My workaround was to instead use the two FX assign button at the top of each channel, so by pressing SHIFT + fx buttons you can cycle through the different effects. However this removes the ability to assign FX units 3 & 4, so in order to maintain this functionality I thought a reasonable compromise is to only allow MixerFX selection if the filter button is active otherwise just control FX units 3 & 4 as it would normally. The following code is the modified part inside of qml/CSI/S8/Channel.qml

AppProperty { id: mixerFXOn; path: app_prefix + "fx.on" }

 AppProperty { id: mixerFX; path: app_prefix + "fx.select" }

 WiresGroup
{
  enabled: !channel.shift
  Wire { from: surface_prefix + "fx.assign.1"; to: TogglePropertyAdapter { path: app_prefix + "fx.assign.1"; } }
  Wire { from: surface_prefix + "fx.assign.2"; to: TogglePropertyAdapter { path: app_prefix + "fx.assign.2"; } }
}

WiresGroup
{
  enabled: channel.shift && (!mixerFXOn.value && fxMode.value == FxMode.FourFxUnits)
  Wire { from: surface_prefix + "fx.assign.1"; to: TogglePropertyAdapter { path: app_prefix + "fx.assign.3"; } }
  Wire { from: surface_prefix + "fx.assign.2"; to: TogglePropertyAdapter { path: app_prefix + "fx.assign.4"; } }
}

WiresGroup
{
  enabled: channel.shift && (mixerFXOn.value || fxMode.value == FxMode.TwoFxUnits)
  Wire { from: surface_prefix + "fx.assign.1"; to: ButtonScriptAdapter { onRelease: { mixerFX.value = (mixerFX.value + 4) % 5; } } }
  Wire { from: surface_prefix + "fx.assign.2"; to: ButtonScriptAdapter { onRelease: { mixerFX.value = (mixerFX.value + 1) % 5; } } }
}

I'd love to know what you think, is this a good compromise or does it just make the whole thing too complicated? Personally I feel like it works for me, as long as I'm not furiously tying to assign FX units 3 & 4.

EDIT: Modified so that it ignores filter conditionality for MixerFX selection if FxMode.TwoFxUnits is true.
Fixed small issue with FX unit assign.

Hey, the mod isn't working on my S8 since updating to 3.2.1. Does anyone know a fix?

Hey mate!
Been a while =)

Would it be possible to implement the cue names displaying at the screens too?

So for example, u have these cue names named within Traktor:

...and they would show like this:

Your instructions for Windows says to Rename the qml folder to qmlBackup then to Copy the qml folder from the download into this folder.. am I to keep the files already in the folder?

Hey bro!

On my YouTube channel, with a demo of your screenhack, I had some people pointing out the Press SHIFT + FLUX to engage flux reverse and Cycle through MixerFX on S8 by pressing SHIFT + FX <1+2> no longer working for S8 users.
Turns out, after updating to 3.1, I had the same issue.
This fixes it: #14 (comment)
Can you override the S8 Channel.xml in next version with the above?

Thank you 👍

Looks like ErikMinekus was able to get the update completed. Much of the work fixing the code should be available via his own screen mod. I'll happily tip a programmer to get this updated and working.

ErikMinekus Mod update: ErikMinekus/traktor-kontrol-screens#26 (comment)

I've installed fresh Traktor 3.3.0 108, changed CSI Defines and Screens folders and nothing changed to screens of S4MK3. MacOS High Sierra 10.13.6 (17G66)

I've updated to Traktor 3.3, installed the new files. Traktor runs and everything seems to be working fine. The only thing that's not working is Key Match Guides in the Browser.

Shows you how good your mod is when I'm freaking out with the default screens :)

I'm on mac sierra, and I see no key offset for valid file matches. Was this feature removed?

It would be great to add colour ranges back for high/mid/low if possible please.

Great job otherwise. Thanks.

Request to add an indicator of which deck is the Tempo Master, possibly to the Deck Header.

Love that you added "beats to cue" on the displays. but what I would love is to have both deck A&B (C&D) displayed In each deck (Like master/deck). Its hard to move the yes from one screen to another to check the phrasing. Otherwise I love ur work and been using it a while now :)
Thanks for listening

Regards Jay

Does anyone know of any way to take the QMLs and have them rendered in an external application?

IE Take Traktor's QML resources and import them either into a new Qt application or into a OBJC view?

or also does anyone know of a way to capture the QML views while Traktor is running and display them elsewhere (without using straight screen capture software). Seem like Traktor only renders one window and one view in Cocoa mode.

thanks

See: http://disq.us/p/1qbbdx5

Which version of Traktor do u use?

If you have any ideas or suggestions drop them down bellow.

The Screen looks like the standard screen exept the key field shows me the camelot key.

Sometimes when the master track changes, the next cue point is not updated correctly.

Because of this, the last cue point cannot be calculated/retained and it causes issues if you switch master tracks manually and one (or both?) do not have next cue points.

Hello Brian,
I have two question In regards to your project in GitHub for the Kontrol s5.
Could you please advise how can I switch from FX unit 1 and 2 to 3 and 4 (deck fx)? Is there any possibility?
I appreciate a lot the beat/phase meter but I'm wondaring is there any chance to be switchable from 1 Bar to 4 Bars per block.

By the way I like a lot your project!!! Great work!!!

Thank you in advance!!!

i find it confusing now when my laptop is showing open key, but the S8 display is showing camelot now.

Can we make the S8 show open key instead, or have an option to do so somehow please?

After last update:

• Filter button does not work, it does not enable/disable filter in Traktor.

• Shift + Filter does not change between MixerFX banks.

I did exactly what was instructed for windows and when I opened Traktor it crashed.. why?

I updated Traktor 3.11.1 and qml mod crashes Traktor opening using D2 anybody got a fix..?

Richard

Hello. I can't get it to work, replace the folder and when I start traktor on my s4 mk3 the screen is as standard.

Sorry my english

Hi,

Can you fix the files, so they work with Traktor 3.9? Thank you for your big work! 🙂

Ran into a problem with the hack using the step sequencer on Traktor 3 using a S8. The beat graphics cover the names of the samples at the top of the display.
If the graphic could be turned off in step sequencer mode it would solve the problem. The graphic isn't really needed because of the sequencer display itself showing the active beat.

Has anyone been able to use the D2 Hack with the new update on 3.2.2?

Hello
Thanks a lot , i like the screens !!
I was looking if it was possible to have Mixer Fx function also for d2 ?
Thanks In advance :)