kondziu / fmltest Goto Github PK

Operator < is used in the array test. It is not mentioned on the courses AST spec.

Please consider modifying the test case object.bc so that it doesn't depend on the fact that object fields are printed in insertion order.

Other test cases pass when fields are printed in lexicographic order, only object.bc doesn't.

5c5
< object(..=object(), x=3, z=2, y=4)
---
> object(..=object(), x=3, y=4, z=2)

I know that it is probably preferable to keep the order of the fields like it is in the source file, but given that in the bytecode fields are already reversed, it seems kind of arbitrary.

Lexicographic sorting is likewise deterministic and if the test cases are compatible with both orderings, everyone should be satisfied. (At least until we start interning the strings and then the easiest order would be the order in which field names appear in the constants array...).