konoui / lipo Goto Github PK

Is the output of lipo reproducible? I.e. will the same input always generate the exact same output?

Hi, and thanks for this great project!

While I suspect it's not as common that the -archs/-info commands are used, I think it's probably good to list it as a difference in functionality from the standard lipo tool.

Currently, when invoking it it produces an error:

$ ./lipo -archs ./mylib.a
Error: can't figure out the architecture type of: ./mylib.a: invalid magic number

# original lipo
$ lipo -archs ./mylib.a
arm64

reserved in fatArchHeader of apple lipo is non-zero value when testing extract/remove/extract_family.
Tests of replace/create will pass with zero values.

		{
			name:   "-extract_family -fat64",
			inputs: []string{"armv7k", "arm64", "arm64e"},
			arches: []string{"arm64"},
			fat64:  true,
		},

		{
			name:   "-remove -fat64",
			inputs: []string{"armv7k", "arm64", "arm64e"},
			arches: []string{"arm64"},
			fat64:  true,
		},

		{
			name:   "-extract -fat64",
			inputs: []string{"armv7k", "arm64", "arm64e"},
			arches: []string{"arm64"},
			fat64:  true,
		},

hexdump /tmp/want-fat64-remove | less
0000000 feca bfba 0000 0200 0000 0c00 0000 0c00
0000010 0000 0000 0000 0040 0000 0000 1d00 d278
0000020 0000 0e00 0000 0100 0001 0c00 0000 0200
0000030 0000 0000 1d00 00c0 0000 0000 1d00 d278
0000040 0000 0e00 0001 0000 0000 0000 0000 0000
0000050 0000 0000 0000 0000 0000 0000 0000 0000

hexdump /tmp/got-fat64-remove | less
0000000 feca bfba 0000 0200 0000 0c00 0000 0c00
0000010 0000 0000 0000 0040 0000 0000 1d00 d278
0000020 0000 0e00 0000 0000 0001 0c00 0000 0200
0000030 0000 0000 1d00 00c0 0000 0000 1d00 d278
0000040 0000 0e00 0000 0000 0000 0000 0000 0000
0000050 0000 0000 0000 0000 0000 0000 0000 0000

hexdump /tmp/want-fat64-extract | less
0000000 feca bfba 0000 0200 0001 0c00 0000 0000
0000010 0000 0000 0000 0040 0000 0000 1d00 d278
0000020 0000 0e00 0000 0100 0001 0c00 0000 0200
0000030 0000 0000 1d00 00c0 0000 0000 1d00 d278
0000040 0000 0e00 0001 0000 0000 0000 0000 0000
0000050 0000 0000 0000 0000 0000 0000 0000 0000

Hello,

if TMPDIR is on a different filesystem than the output file the operation fails:

root@d27ae656b029:/workspace# /go/bin/lipo -output foo -create foo.amd64 foo.arm64
Error rename /tmp/tmp-output-binary680144686 foo: invalid cross-device link
create:
  Create an universal binary(fat binary) from input thin binaries. 
  e.g. lipo path/to/binary.x86_64 path/to/binary.arm64e -create -output path/to/fat-binary

It's probably os.Rename that needs a fallback:

Thanks,
Gregor

This is useful for environments such as CI/CD which does not provides macOS or macOS lipo

macos github action has lipo but it is expensive: https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions

Thanks to this tool, we can still use cheaper Linux github actions 👍 Maybe we can mention that to the readme.

Original macOS lipo can overwrite input file when it is specified as output. But v0.2.3 can't overwrite file:

lipo -thin x86_64 my_file -output my_file
Error failed to write binary data: EOF

This feature used by pyInstaller.