kontaras / legendarystats Goto Github PK

First of all, there are too many different customs to have them all added in, so they are going to be along the lines of "Custom Scheme", "Custom Hero 1", "Custom Hero 2", ... "Custom Hero 10".

Further, I am a bit hesitant to include them in the stats since:

1. I assume that once you add in any custom contents to a play, I need to turn off all verification (who said that no one will create a hero that adds in an extra henchman group or mastermind during setup).
2. I assume that a lot of the custom contents is not going to have the same balance as the official contents. Epic masterminds are going to skew stats enough as it is, without stupidly overpowered heroes and villains.

Maybe once there is a game logging community, we will be able to come up with a good way to add customs.

For example, for schemes that put a hero in the villain deck, add to the scheme summary page to have a table of win rates by hero used for this.

In order to add in the rules engine, we need to have the Kotlin rules engine product built as part of the server build and get jar and js artifacts from it.

Things to check:

• Valid hero/villain/henchman/mastermind/scheme ids are all in valid ranges
• Verify the correct number of heroes, villains, and henchmen
• Mastermind "Always leads" respected (except for solo)
• Scheme specific set up rules
• Check for duplicate card sets Not possible with base set alone
• Check that game outcome is a valid one Not possible with base set alone

The (prod) deploy script should be able to handle a fresh deploy as well as update an existing deployment. Currently, it only does the former.

The rules project is still not being monitored by Sonar or CodeCov. It is not worth holding up other work for this, but this is tech debt that needs to be addressed.

Originally posted by @kontaras in #115 (comment)

The Kotlin rules engine contains constants for all card sets and exports them to Java and JavaScript. This means that we have the same data stored twice in the program (both in SQL and Kotlin) and they are time consuming to write.

It would be nice to generate these files based on data in the database.

Enough server side logic to take in a play from the UI and write it to the DB

Contents:

• Conditional win rates (hero win rates vs a mastermind, etc.)

• How many logged plays do you have?
• What sort of format do you use? Would you mind including some sample plays?
• If often play solo, what rules do you use?
• When not playing solo, do you include the “leads” villain groups?
• Should I include custom cards? What sort of rules enforcement should there be? Include in stats?
• How often do you replay the same setup during multiple play sessions?
• How often do you replay a previous setup with minor tweaks?
• Do you ever mix in contents from other Legendary games? How often?

The rules project is still not being monitored by Sonar or CodeCov. It is not worth holding up other work for this, but this is tech debt that needs to be addressed.

Originally posted by @kontaras in #115 (comment)

Pick out a domain name and register it

When a user selects if they prefer MCU/DXP/Comic sets, that should be persisted for other pages.

Add a page to get card set stats for various player counts

There are several instances of copy and pasted code in controllers that share logic for all card set types:

• https://sonarcloud.io/project/issues?id=knary_LegendaryStats&issues=AXtC4s2BR6tbtusmp4l_&open=AXtC4s2BR6tbtusmp4l_
• https://sonarcloud.io/project/issues?id=knary_LegendaryStats&issues=AXtC4s4OR6tbtusmp4mA&open=AXtC4s4OR6tbtusmp4mA

Add a win rate table for player counts

• Add card sets to database
• Add rules scripting
• Add features to game entry form to allow extra hero in villain deck (Transform Citizens Into Demons and X-Cutioner's Song)
• Check for duplicate card sets
• Check that game outcome is a valid one

If possible, this should be a (timezone agnostic) date.

There are several sites out there that let people generate games. It would be nice to have an API to import game setups.

Tasks:

• Generate format for submitting games (JSON?), let users copy in well-formatted games
• Create API endpoint
• Authentication?

This will be useful for logging retried plays

The script does not generate scheme specific rules.

Originally posted by @kontaras in #99 (comment)

Add a gradle build to the utils directory which calls sub-dir scripts and add scripts to the sub-dirs to build and test the code in them.

Certain characters have a card set name that is repeated in other sets. They are:
Deadpool (Core and Deadpool)
Thor (Core and Heroes of Asgard)
Wolverine (Core and Dark City)

Heroes in other sets are
Beast (Secret Wars 1 and X-Men)
Daredevil (Dark City and Civil War)
Nova (Champions and Cosmos)
Peter Parker (Civil War and Homecoming)
Venom (Villains and Venom)

Pure win percentage does can paint a different picture depending on the Masterminds and Schemes a card tends to be used with. A card from the base set probably gets plenty of plays with (easy) base set masterminds. A card from a hard large set (like X-Men) will probably get many plays against difficult masterminds.

It would be nice if we could estimate the average difficulty of the setups a card was in and factor it into win rate.

Package names should start with games.lmdbg.

Remove all references to kon.* from the codebase.