korving-f / daca Goto Github PK

Currently the local anisble provisioner is used to provision VMs. It would be nice to support Host-based ansible as well.

The current jinja2 templates, Vagrant triggers and ansible/shell provisioners assume systems are Debian-based Linux systems. This should ideally be expanded so lab environments can be spun up using things like Windows workstations and/or

This would also allow for new artifacts to be collected like EVTX and ETW trace files.

TODO

• Add logger.debug() statements for future quick debugging while running scenarios.
• Write some more tests (e.g. scenario validation / discovery etc.)
• Explicit docstrings, argument datatypes and return values everywhere. (+ pep8 adherence using pylint)

Setup a ci/cd pipeline with:

• bandit
• pylint
• pytest
• codecov

Also think about functional / integration tests; does running certain scenarios actually produce output?
Perhaps create a test scenario for this.

Setup pipenv or requirements.txt for this project to keep an eye on dependencies and required python versions.

See for example numpy's badge in README.

Wrapping the scenario's into something like docker-compose should work similarly to the VagrantController.
This requires better definition of the Controller interface.

Vagrant 3 is coming and then this project might need to be updated (e.g. templated Vagrant files) since it relies heavily on otherwise unmaintained python client for Vagrant 2.x.

See also Vagrant 3.0 Announcement

When a run or setup section contains a reference to a file (e.g. ansible playbook file or script), an additional validation step should be added to check if the file exists.

Instead of running all scenarios locally, supporting a terraform wrapper would allow for cloud-native sampling.

• Terraform CDK
• CDKTF Python
• CDKTF installation

Currently no good tests exist, when tests get added a coverage report should be generated through e.g. Codecov.

Because the Jinja2 template / Scenario go through multiple steps of pre-processing, some scenarios using standard Jinja2 functionality breaks while it shouldn't.

# Does work: variables and filters
{{ some_variable | to_nice_json }}

# Does not work: statements
{% set my_var= "something" %}

# Untested: comments
{# my super duper comment #}