kouzukii / ffxiv-priceinsight Goto Github PK

On the player option, when the tooltip is set fixed, it's position is sliding down (an up) each time I hover an item.
I need to move it back with the ATH menu.
I still have the issue when I disable "Simple Tweaks" and "Wich Patch Was That?".

I made a video in case my explanation was not clear.
https://www.youtube.com/watch?v=Pk_3aNYAcHE

Hello, The plugin Price Insight doesn't pull the price(s) anymore. I've used ALT to "retry", also right clicking the plugin and Reset Data and Reload option. The plugin seems to load fine, no error about it. I have checked the console about this and it shows an error.

11:48:38.354 ERR | [PlayerTrack] Failed to process lodestone requests. 11:48:38.354 ERR | System.AggregateException: One or more errors occurred. (The requested address is not valid in its context. (api.kalilistic.io:443)) 11:48:38.354 ERR | ---> System.Net.Http.HttpRequestException: The requested address is not valid in its context. (api.kalilistic.io:443) 11:48:38.354 ERR | ---> System.Net.Sockets.SocketException (10049): The requested address is not valid in its context. 11:48:38.354 ERR | at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken) 11:48:38.354 ERR | at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token) 11:48:38.354 ERR | at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|281_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken) 11:48:38.354 ERR | at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken) 11:48:38.354 ERR | --- End of inner exception stack trace --- 11:48:38.354 ERR | at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken) 11:48:38.354 ERR | at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken) 11:48:38.354 ERR | at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken) 11:48:38.354 ERR | at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem) 11:48:38.354 ERR | at System.Threading.Tasks.TaskCompletionSourceWithCancellation1.WaitWithCancellationAsync(CancellationToken cancellationToken)
11:48:38.354 ERR | at System.Net.Http.HttpConnectionPool.HttpConnectionWaiter1.WaitForConnectionAsync(Boolean async, CancellationToken requestCancellationToken) 11:48:38.354 ERR | at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken) 11:48:38.354 ERR | at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken) 11:48:38.354 ERR | at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken) 11:48:38.354 ERR | at PlayerTrack.Domain.LodestoneService.GetCharacterIdsAsync(List1 requests) in /work/repo/PlayerTrack.Domain/Services/LodestoneService.cs:line 188
11:48:38.354 ERR | --- End of inner exception stack trace ---
11:48:38.354 ERR | at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
11:48:38.354 ERR | at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification) 11:48:38.354 ERR | at PlayerTrack.Domain.LodestoneService.SendBatchRequest(List1 batchedRequests) in /work/repo/PlayerTrack.Domain/Services/LodestoneService.cs:line 136
11:48:38.354 ERR | at PlayerTrack.Domain.LodestoneService.ProcessRequests(Object sender, ElapsedEventArgs e) in /work/repo/PlayerTrack.Domain/Services/LodestoneService.cs:line 118`

Not sure what this is, as I've never done anything with code before, but, it just repeats this specific error everytime it updates / refreshes itself.

After the newest update whenever you Right Click to sort inventory it crashes the game. Tested it a few different times to make sure it was this plugin causing the issue and sure enough whenever I disable it I can sort without crashing.

Not sure when this happened, but I don't see the price suggestion anymore.

I really don't enjoy having to hold ctrl to fetch prices on items. Consider fetching item prices in the background for inventory items?

Config window doesn't seem to respect Dalamud UI scaling. This is on a 4k display with Dalamud global UI scale at 2.5.

my prices are sometimes not refreshing when I check the marketboard. this used to work just fine, but as of recently it stopped.

If a tooltip is too tall to fit on screen when using the fixed tooltip position option, it normally will offset to stay on screen:

Other plugins that add entries to the tooltip, such as AllaganTools, maintain this functionality. However, PriceInsight's entries will cause an overflow:

The price and the bottom of the tooltip are offscreen and not visible.

The dark background does not scale to the amount of lines/text:

I don't know exactly but I think this started happening after the latest patch.

Plugin needs to be updated for the new Dalamud release.

For long tooltips that rests on bottom of screen, the price display is cut off like thus:

Hello.
Problem with french client.
The price display is bugged for numbers with more than 3 digits (ie 1 000, 10 000, etc). It shows an equal symbol instead of a comma or an empty space.

I've noticed that since the last update, where the region and datacenter travel was added I was getting severe lag/high ping issues, it's like it's fetching all the catched prices from universalis every area change, ping can go as far as 3000+ (using PingPlugin from karashiiro in Dalamud to check it) and well is obviosuly noticeable in game, while Price Insigh is disabled I don't get this bad ping, even with mudifish enabled things get crazy, my ISP download speed is about 220MB download and 50MB upload, my ISP is over NAT but I still don't think the issue comes from there, but idk. Is there an option to chose when this update prices? (like cache prices every 90 min) or is just borke rn? I had the alt option for update prices on (even if I don't use it, I prefer to hover over items) but even not trying to check prices this happens, no matter if my inventory is not even opened.
I really like the idea behind this plugin, but that lag is severely bad, maybe a button for togle off/on could patch the problem for a while, like turn on when you need it, but in general I can't have this on without severe lag.

Updated plugin on 7th september of 2023 and a bug appeared that made text color wrong for my current UI theme (light).

Sorry for the log spam but here are the resolutions i've tried locally

1. disabled other plugins
2. enabled

10:01:50.122 | INF [LOCALPLUGIN] Unloading PriceInsight.dll

10:01:50.634 | INF [LOCALPLUGIN] Finished unloading PriceInsight.dll

10:01:51.622 | DBG HandlePrintMessageDetour String modified: System.Byte -> Dalamud.Game.Libc.StdString(2181820208400)

10:01:53.787 | INF [LOCALPLUGIN] Loading PriceInsight.dll

10:01:54.015 | INF [LOCALPLUGIN] Finished loading PriceInsight.dll

10:01:54.326 | ERR [PriceInsight] Failed to retrieve data from Universalis for itemIds [12518, 37282, 6141, 8142, 27788, 19873, 21288, 20016, 19878, 5324, 5333, 5596, 19921, 14284, 36182, 5504, 5597, 5259, 5598, 27960, 38264, 14282, 8144, 13715, 36060, 5740, 37823, 5590, 36241, 8147, 27870, 27871, 33916, 4856, 5133, 36227, 36223], scope "North-America".
System.Net.Http.HttpRequestException: Invalid status code 525
at PriceInsight.UniversalisClient.GetMarketBoardDataList(String scope, UInt32 homeWorldId, List`1 itemId) in /work/repo/UniversalisClient.cs:line 64

10:01:54.325 | ERR [PriceInsight] Failed to retrieve data from Universalis for itemIds [33930, 5385, 33919, 5402, 5325, 33934, 4639, 25193, 33920, 5888, 33932, 33942, 27878, 5807, 14279, 27864, 14276, 27865, 23185, 5351, 12861, 4813, 4792, 5434, 4789, 5291, 5352, 5728, 5288, 5498, 5482, 5470, 5729, 5492, 5432, 5488, 5471, 5442], scope "North-America".
System.Net.Http.HttpRequestException: Invalid status code 525
at PriceInsight.UniversalisClient.GetMarketBoardDataList(String scope, UInt32 homeWorldId, List`1 itemId) in /work/repo/UniversalisClient.cs:line 64

10:01:54.324 | ERR [PriceInsight] Failed to retrieve data from Universalis for itemIds [21800, 33938, 4868, 7146, 4803, 12594, 5270, 37696, 8149, 28724, 8150, 36061, 5275, 7671, 36247, 5708, 7621, 2585, 36209, 19993, 27742, 12652, 5594, 27959, 5595, 37283, 6163, 36116, 36109], scope "North-America".
System.Net.Http.HttpRequestException: Invalid status code 525
at PriceInsight.UniversalisClient.GetMarketBoardDataList(String scope, UInt32 homeWorldId, List`1 itemId) in /work/repo/UniversalisClient.cs:line 64

10:01:54.330 | DBG [PriceInsight] Fetching 29 items took 291ms

10:01:54.330 | DBG [PriceInsight] Fetching 37 items took 285ms

10:01:54.330 | DBG [PriceInsight] Fetching 38 items took 281ms

10:01:54.339 | ERR [PriceInsight] Failed to retrieve data from Universalis for itemIds [12878, 27968, 5510, 23178, 5516, 3537, 5536, 13763, 12937, 8020, 4332, 19928, 19929, 15838, 16833], scope "North-America".
System.Net.Http.HttpRequestException: Invalid status code 525
at PriceInsight.UniversalisClient.GetMarketBoardDataList(String scope, UInt32 homeWorldId, List`1 itemId) in /work/repo/UniversalisClient.cs:line 64

10:01:54.340 | DBG [PriceInsight] Fetching 15 items took 291ms

10:01:54.342 | ERR [PriceInsight] Failed to retrieve data from Universalis for itemIds [37840, 33925, 25195, 12888, 33939, 6159, 17837, 10386, 5057, 5262, 16911, 36215, 17656, 5058, 5065, 12525, 19943, 19945, 5785, 30116, 5741, 25187, 33933, 5734, 13115, 33931, 33921, 30128, 33918, 27712, 4559, 22447, 33928, 30129, 25197, 33917, 27715, 27854, 7024, 5367, 7894, 25190], scope "North-America".
System.Net.Http.HttpRequestException: Invalid status code 525
at PriceInsight.UniversalisClient.GetMarketBoardDataList(String scope, UInt32 homeWorldId, List`1 itemId) in /work/repo/UniversalisClient.cs:line 64

10:01:54.343 | DBG [PriceInsight] Fetching 42 items took 294ms

10:01:54.344 | ERR [PriceInsight] Failed to retrieve data from Universalis for itemIds [3771, 13726], scope "North-America".
System.Net.Http.HttpRequestException: Invalid status code 525
at PriceInsight.UniversalisClient.GetMarketBoardDataList(String scope, UInt32 homeWorldId, List`1 itemId) in /work/repo/UniversalisClient.cs:line 64

10:01:54.344 | DBG [PriceInsight] Fetching 2 items took 295ms

10:01:54.346 | ERR [PriceInsight] Failed to retrieve data from Universalis for itemIds [14181, 17836, 5066, 5068, 12524, 27706, 26744, 5064, 4730, 4642, 4640, 4660, 4710, 4645, 4679, 12866, 12842, 19517, 11915, 27111, 19561, 11923, 2386, 2383, 2380, 35328, 2442, 2448, 2416, 11880, 27100, 2551, 2471, 2472, 2473, 30446, 31997], scope "North-America".
System.Net.Http.HttpRequestException: Invalid status code 525
at PriceInsight.UniversalisClient.GetMarketBoardDataList(String scope, UInt32 homeWorldId, List`1 itemId) in /work/repo/UniversalisClient.cs:line 64

10:01:54.346 | DBG [PriceInsight] Fetching 37 items took 296ms

10:01:54.452 | ERR [PriceInsight] Failed to retrieve data from Universalis for itemIds [5395, 12579, 27750, 5277, 5518, 5512, 31962, 32003, 32000, 31996, 31990, 31989, 31986, 19535, 31987, 31988, 27127, 31998, 29662, 29663, 31118, 31759, 32215, 7722, 7731, 15865, 20795, 30441, 27078, 11875, 2345, 2342, 2340, 11881, 2374, 2370, 2366, 27713, 27714], scope "North-America".
System.Net.Http.HttpRequestException: Invalid status code InternalServerError
at PriceInsight.UniversalisClient.GetMarketBoardDataList(String scope, UInt32 homeWorldId, List`1 itemId) in /work/repo/UniversalisClient.cs:line 64

10:01:54.453 | DBG [PriceInsight] Fetching 39 items took 403ms

10:01:55.759 | DBG HandlePrintMessageDetour String modified: System.Byte -> Dalamud.Game.Libc.StdString(2183801293216)
{ } [ Send ]

I know this is probably an issue on Universalis side, but I figured I'd raise an issue anyway since it might be nice to know about, and it's something I've never seen happening until today. Plus it might be good to handle this supposedly invalid status code in case it happens again.

Game tooltips are showing the following:

Pressing ALT in this instance fixes the issue for that particular item.
So it might be related to the option of prefetching the prices for items in inventory.

My settings are:

And the exception in the log:

15:13:19.848 | ERR [PriceInsight] Failed to retrieve data from Universalis for itemIds [{ItemID List truncated for privacy}], scope "{Server Name truncated for privacy}".
System.Net.Http.HttpRequestException: Invalid status code InternalServerError
   at PriceInsight.UniversalisClient.GetMarketBoardDataList(String scope, UInt32 homeWorldId, List`1 itemId) in /work/repo/UniversalisClient.cs:line 63

(ID list and server removed because I don't know if this information can be linked to me by SE and counts as an admission to breaking the ToS, but if I'm just being silly and you need that information, feel free to let me know)

Most of the time the price indicator in the item's description shows up as "Marketboard info is being obtained" but it never does.
And sometimes it straight up doesn't show anything.

It may be a problem with universalis themselves because another Plugin I use "personal market board" ALSO doesn't fetch prices and current sales correctly and displays nothing instead.

Edit : I haven't been able to see Universalis prices in games through your plugin or any other for about a month now.

I noticed that when you enable datacenter/region price insights, it changes the "sales per day" and "average sale price" display to count those instead of your home server, in the order of Home -> Datacenter -> Region depending on which is ticked.

It would be nice if there was a checkbox that let you limit those to your home server, since your retainer can only sell on your own server and sometimes prices and daily sales vary wildly between servers due to population, which pollutes the data.

Instead of showing home world of current character it shows home world of the first character you logged in when you launched the client. Home world does not change when you log in a character on another world.

Here it shows Home (Phantom) even tho this characters home world is Sagittarius

I was checking the price on supply mission items. Then the black box that pops whenever you press ctrl to fetch the updates keeps flickering as if ctrl is being constantly held down. This behavior doesn't happen in Inventory/Crafting list. (I'm not sure where else I can check for it.)

Timers > Next Mission Allowance > Hover over anything

Hello, it would be nice if we could have a setting that would allow us to see the Approved item price when hovering a non-approved item

Looks like text isnt rendering correctly in the tooltip since the patch.

In many cases the worth of an item is not just how much it sells for but how fast it sells (because there is a cost associated with storing the item and keeping a retainer slot or inveotry used up). It would very nice if the sales/week of said item were displayed on the tooltip, along the average/min price.

Usually I set my "item help" window in the bottom left corner, like so:

However, after installing the priceinsight plugin, the "item help" window is constantly pushed to the top of the screen the second I mouseover an item. The height that it is pushed up appears to be linked to how high the window needs to go for the price insights to show up. This causes the user to need to constantly open up the HUD Layout to change the "item help" window back into its original position.

A fix would be greatly appreciated, as the plugin itself is extremely useful.

For example Fleeting Brand has two versions: one caught with Collector's Glove buff up and one caught without that buff. The former is market prohibited but shows a tooltip price, too.

Been getting these on everything when hovering over items. Not sure if it's because of an update to this plugin or something else that changed on my machine.

From /xllog:

17:48:18.662 ERR | [PriceInsight] Failed to retrieve data from Universalis for itemId 17633, scope "Aether".
17:48:18.662 ERR | System.Net.Http.HttpRequestException: The requested address is not valid in its context. (universalis.app:443)
17:48:18.662 ERR | ---> System.Net.Sockets.SocketException (10049): The requested address is not valid in its context.
17:48:18.662 ERR | at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
17:48:18.662 ERR | at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
17:48:18.662 ERR | at System.Net.Sockets.Socket.g__WaitForConnectWithCancellation|281_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
17:48:18.662 ERR | at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
17:48:18.662 ERR | --- End of inner exception stack trace ---
17:48:18.662 ERR | at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
17:48:18.662 ERR | at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
17:48:18.662 ERR | at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
17:48:18.662 ERR | at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
17:48:18.662 ERR | at System.Threading.Tasks.TaskCompletionSourceWithCancellation1.WaitWithCancellationAsync(CancellationToken cancellationToken) 17:48:18.662 ERR | at System.Net.Http.HttpConnectionPool.HttpConnectionWaiter1.WaitForConnectionAsync(Boolean async, CancellationToken requestCancellationToken)
17:48:18.662 ERR | at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
17:48:18.662 ERR | at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
17:48:18.662 ERR | at System.Net.Http.DecompressionHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
17:48:18.662 ERR | at System.Net.Http.HttpClient.g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
17:48:18.662 ERR | at PriceInsight.UniversalisClient.GetMarketBoardData(String scope, UInt32 homeWorldId, UInt64 itemId) in /work/repo/UniversalisClient.cs:line 31

Hi, cool mod, but noticed that you still don't have it up on the repo, as well as having duplicates of mods already in the default one.
Could you please add a working repo?

when refreshing prices with the marketboard hq items seem to stay stuck at X hours but NQ are showing as updating instantly
HQ

NQ

Universalis

Can see universalis updated with new prices,
priceinsight is still showing HQ price cache from 2h ago. NQ has updated 34 mins ago.

This is after using alt to force a refresh as well.

I've been trying to update the plugin but it has been outdated and incompatible since patch 6.2. Was wondering if this is expected still?

When I hover on an item, it will say something like 300g (15h ago) but in fact the price was just updated, so I'm lead to believe that the 15h calculation is just a bug. I'm constantly needing to do mental math to guess the actual freshness of the price.

Is this a known issue or a limitation? If not, I can try to help investigate if needed.

Dalamud released just recently for Update 6.1 and the API has shifted as a result.

Whiles hovering over regular gear items the UI card is too big and its bottom is being cut. Prices are not visible on these items for me.