kozickikarol / pyhockey Goto Github PK

• New file in tests folder
• I think we should test all methods
• Remember - you can create few tests for one method - to simulate all cases - too small tests are better than too big

+If you are not sure what this class should contain take a look at https://github.com/KaRi94/PyHockey/wiki/Podzia%C5%82-na-poszczeg%C3%B3lne-klasy, but feel free.

+Provide some nicely developed images for Mallets (red/blue).

+Remember about setters and getters.

+If there is anything impossible to implement due to lack of others classes just leave comment TODO and do it when project becomes more clear.

+If you are not sure what this class should contain take a look at https://github.com/KaRi94/PyHockey/wiki/Podzia%C5%82-na-poszczeg%C3%B3lne-klasy, but feel free.

+Find some nicely developed image for Disc.

+If there is anything impossible to implement due to lack of others classes just leave comment TODO and do it when project becomes more clear.

+Remember about setters and getters.

+If you are not sure what these classes should contain take a look at https://github.com/KaRi94/PyHockey/wiki/Podzia%C5%82-na-poszczeg%C3%B3lne-klasy, but feel free.

Adjust goal size:

Add goal width:

Goal center: (pitch_x_max+pitch_x_min)/2
Goal should exist from goal_center-width/2 to goal_center+width/2

We have talked about it. You saw it. It's funny but game is not playable :)

+If you are not sure what these classes should contain take a look at https://github.com/KaRi94/PyHockey/wiki/Podzia%C5%82-na-poszczeg%C3%B3lne-klasy, but feel free.

+Remember about setters and getters.

+For now Scoreboard doesn't have to be beautiful, just usable.

+If there is anything impossible to implement due to lack of others classes just leave comment TODO and do it when project becomes more clear.

Mallet and Disc don't have many methods. Moreover they aren't complilated so it should be easy.
You can for example create tests for accelerate, load_image, move_to.

• Create TestVector.py file in tests folder
• Create unittests for nontrivial methods such as cross, normalized, angle etc.
• If it is needed use mocks

+If you are not sure what these classes should contain take a look at https://github.com/KaRi94/PyHockey/wiki/Podzia%C5%82-na-poszczeg%C3%B3lne-klasy, but feel free.

+Find some nicely developed background for Pitch (horizontally).

+Barriers of pitch should be smaller than background because we also want display Scoreboard and small camera image.

+I think it would be good if goals barriers were little inside the pitch.

+There should be method which allows to draw it

Also try to detect object by it's colour. We can assume that it will be red or blue object.

https://www.pygame.org/docs/ref/draw.html

Background should be transparent.
Although You don't have to worry about image size (we can use transform.scale), remember about proper aspect ratio.