Giter VIP home page Giter VIP logo

Comments (12)

charleslcso avatar charleslcso commented on May 12, 2024

Ok. Typing ads.yahoo.com, beap-gc.yahoo.com in Safari returns about:blank, which is good.

But going to news.yahoo.com.hk and all ads from the above addresses aren't blocked.

from blockparty.

krishkumar avatar krishkumar commented on May 12, 2024

Thanks for finding this issue.

By the way, it is not ideal to block ads.yahoo.com, etc if the URL was typed directly in Safari. I will be pushing a fix which addresses this issue.

from blockparty.

charleslcso avatar charleslcso commented on May 12, 2024

It seems that no one (Freedom, ad-blocker, safari blocker, 1blocker, purify, just content, adblocker, crystal, adblocker) manage to block ads in news.yahoo.com.hk

from blockparty.

krishkumar avatar krishkumar commented on May 12, 2024

Impressive work by Yahoo! :)

from blockparty.

krishkumar avatar krishkumar commented on May 12, 2024

I see that ads are being blocked now on news.yahoo.com.hk. Feel free to re-open this issue if you are still seeing the ads.

from blockparty.

matrixfox avatar matrixfox commented on May 12, 2024

Those advertisements are not coming from a script, but more of a fancy web server proxy injection.

I recently discovered they're coming from "beap.gemini.yahoo.com". If you add this block rule, the advertisements will no longer be clickable. Unfortunately, blocking images will break the site.

I'm also impressed with their work.

{
 "trigger": {
 "url-filter": "beap.gemini.yahoo.com"
 },
 "action": {
 "type": "block"
 }
}

from blockparty.

krishkumar avatar krishkumar commented on May 12, 2024

Good find. Will you be able to submit a PR to the block list with this rule?

from blockparty.

matrixfox avatar matrixfox commented on May 12, 2024

You're gonna love this. It's the "load-type" : ["third-party"] that's allowing ads.

Adding first-party seems redundant. So, I completely removed load-type all together. Probably not the best decision, but she works!

from blockparty.

charleslcso avatar charleslcso commented on May 12, 2024

I added beap.gemini.yahoo.com into the block list and tried before I submit this ticket.

@krishkumar it's still showing ads....

@matrixfox I'll check your suggestion and recompile tonight and try again

from blockparty.

charleslcso avatar charleslcso commented on May 12, 2024

@matrixfox if it works we have a winner! Would we be able to beat yahoo on this ;-)

from blockparty.

krishkumar avatar krishkumar commented on May 12, 2024

Thanks @matrixfox. Yeah first-party blocking rules are not ideal. The original website will not load anymore and it confuses users and developers alike.

from blockparty.

matrixfox avatar matrixfox commented on May 12, 2024

@krishkumar Sites works file for me...

P.s. Ugh, @krishkumar you're right. I'm too busy going from A to Z, I forget theres 24 letters in between.

from blockparty.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.