Comments (7)
Coveralls is included in the Gemfile, which allows it to be built locally.
I'm curious, why are you trying to build a Debian package with the test suite included?
from wisper.
@bmorrall the debian infrastructure runs test suites automatically when building packages whenever they are present. we like to configure them so they run properly: this way we can more easily see if a change in dependency libraries or ruby version has the effect of breaking functionality in some package.
from wisper.
🤔 Is it possible to do bundle install
as part of the build step for the tests this will install all the development/test dependencies which are in Gemfile
?
from wisper.
There is a second option and that is something like:
begin
require 'coveralls'
rescue LoadError
# no-op
else
Coveralls.wear!
end
from wisper.
@krisleech so I sought out some feedback from fellow ruby packagers since I'm still very fresh in that set of tech skills. I should've known better, but ain't that always the case for something -- especially for beginners hehe. coveralls is not required at all for the purpose of running the test suite, so I could've patched it out of spec_helper.rb
.
the patch you suggested in your last message seems to answer perfectly to that need, so if you and other contributors are comfortable merging that in, it would solve the issue for me. however it might mean that some developers won't update coverage information systematically since it won't be compulsory to run coveralls anymore. if some ppl are not super comfortable, I can patch it at packaging level.
from wisper.
@lelutin Personally, I'm using env vars to be able to "opt-out" in such situations if packaging stuff for Debian.
from wisper.
I'm happy with the rescue
no-op solution if someone wants to submit a PR.
from wisper.
Related Issues (20)
- 'console' and 'setup' executable names too general and conflict with other gems HOT 2
- Please release new version without `console` HOT 7
- What's the proper way to test global listeners? HOT 1
- Any suggestions for how to persisting events? HOT 1
- Should we choose WisperNext over Wisper? HOT 1
- An exception raised inside a listener is logged but not raised
- Using Fibers breaks the execution of Wisper HOT 1
- Ruby 3.0 support for broadcast with kwargs HOT 14
- Unable to unsubscribe global listeners in Rails 6 when config.cache_classes is false HOT 1
- Does this work with Ruby 3 yet? HOT 1
- Fix Travis CI HOT 1
- switch from `master` to `main` as primary branch
- Build status badge (image) broken on README HOT 1
- Please modify your gemspec to take the local bin directory out of the global $PATH HOT 1
- Release Wisper 3.0-rc1 HOT 2
- Release wisper 3.0.0 HOT 2
- Request to Contribute Documentation Updates HOT 1
- An easy way of disabling wisper within a block HOT 1
- console" from wisper conflicts with installed executable from fastlane HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wisper.