Comments (14)
wisper 3.0.0.rc1 has been released
from wisper.
#192 is compatible with >= 2.7
, so for all officially supported ruby versions but 2.6
. For 2.6
the ruby team writes: In security maintenance phase (will EOL soon!)
.
The only solution I see to make it compatible with 2.6
and 3
is to use ruby2_keywords. I am not sure if supporting 2.6
is worth the hassle (EOL soon). What do you think?
from wisper.
@krisleech - I opened #197 to address this, hopefully. Wondering if you could take a look when you get a chance, thanks!
from wisper.
@krisleech I regret coming off as an entitled whiner. It makes sense that that would be triggering for you, especially as the author. No real excuses, I just remember being short on time and short on options for what I needed that week.
I appreciate your work!
from wisper.
If anyone else is encountering this, I fixed it by monkey patching wisper
on my codebase:
module Wipser
module Publisher
# Wisper 2.0.1 does not properly support Ruby 3 kwargs
def broadcast(event, ...)
registrations.each do |registration|
registration.broadcast(clean_event(event), self, ...)
end
self
end
end
end
I'd create a PR but ...
won't work for lesser ruby version so I'm not exactly sure what to do.
from wisper.
I opened #192 to hopefully make it compatible with ruby 3, needs some more testing though to make sure it really works like intended!
from wisper.
I'd love to get Ruby 3.0 support in Wisper. But it would need to be backwards compatible. Otherwise we would need to release a new major version dropping Ruby 2.x support and maintain both major versions until Ruby 2.x is EOL, which will be a long time.
from wisper.
We can do a major version release which drops support for 2.6, we need to document it in the CHANGELOG, that it is a breaking change.
from wisper.
If anyone wants to pick this up it would be great. We can drop support for EOL Rubies and add Ruby 3 keyword arguments support.
from wisper.
I think someone should just publish a clone of this that is ruby 3 ready. The wisper-next gem isn't as full-featured yet as this, and the async functionality for that doesn't seem to be ready either.
from wisper.
I think someone should just publish a clone of this that is ruby 3 ready. The wisper-next gem isn't as full-featured yet as this, and the async functionality for that doesn't seem to be ready either. Frustrating.
@benlieb You can create a clone, you can contribute to wisper-next. You could make the changes needed on the PR to allow it to be merged and released. You haven't paid anything for this software, you have no right to complain, zero. You aren't entitled to free labour. Do you or the company you work for donate anything to open source projects?
from wisper.
Any news on this?
from wisper.
Just waiting on #197
from wisper.
Anyone on this thread please try #205 on your codebase and report back any issues... We are close to a release if we can get this tested on some production codebases.
from wisper.
Related Issues (20)
- 'console' and 'setup' executable names too general and conflict with other gems HOT 2
- 'coveralls' missing as a build dependency in gemspec HOT 7
- Please release new version without `console` HOT 7
- What's the proper way to test global listeners? HOT 1
- Any suggestions for how to persisting events? HOT 1
- Should we choose WisperNext over Wisper? HOT 1
- An exception raised inside a listener is logged but not raised
- Using Fibers breaks the execution of Wisper HOT 1
- Unable to unsubscribe global listeners in Rails 6 when config.cache_classes is false HOT 1
- Does this work with Ruby 3 yet? HOT 1
- Fix Travis CI HOT 1
- switch from `master` to `main` as primary branch
- Build status badge (image) broken on README HOT 1
- Please modify your gemspec to take the local bin directory out of the global $PATH HOT 1
- Release Wisper 3.0-rc1 HOT 2
- Release wisper 3.0.0 HOT 2
- Request to Contribute Documentation Updates HOT 1
- An easy way of disabling wisper within a block HOT 1
- console" from wisper conflicts with installed executable from fastlane HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wisper.