While working on a project using ActivityStreams I thought I'd try using the new System.Text.Json source generation.

Unfortunately there's an issue because the converter types are internal.

[JsonSerializable(typeof(Person))]
public partial class ActivityStreamJsonSerializerContext : JsonSerializerContext {}

Produces the following compiler errors.

error CS0122: 'LinkConverter' is inaccessible due to its protection level
error CS0122: 'EndpointsOrLinkConverter' is inaccessible due to its protection level
error CS0122: 'ObjectOrLinkConverter' is inaccessible due to its protection level
error CS0122: 'ImageOrLinkConverter' is inaccessible due to its protection level
error CS0122: 'CollectionPageOrLinkConverter' is inaccessible due to its protection level
error CS0122: 'TermDefinitionConverter' is inaccessible due to its protection level
error CS0122: 'XMLTimeSpanConverter' is inaccessible due to its protection level

Could the converters please be changed to public?

It would be very useful if all Object instances had @context be equal to new List<ReferenceTermDefinition>() { new(new("https://www.w3.org/ns/activitystreams")) } by default and for the Type to be overridden by each inheriting class as I basically set this for all new objects I create manually. We just need to be sure that we don't use these defaults when we parse objects from JSON. One way to achieve this is by only having it (the default) on the Object class, not the IObject interface which is used for serialization/deserialization.

Of cause, we need to ensure that this doesn't break any of the existing tests.