ksivamuthu / aws-copilot-github-action Goto Github PK

Hey,

Thanks for this action, it seems like it could be super useful!

However, using the deploy action leads to an infinite hang as the CLI tool waits for me to choose something!

I've worked around this by running the command directly but I think I must be missing something in how this action is supposed to be used!

Here's how I'm using it:

      - uses: ksivamuthu/[email protected]
        with:
          command: deploy
          app: ${{ github.event.repository.name }}
          env: integration
          force: true

Any help appreciated!

Hi, Thank you for releasing this library!

I am hitting the rate limit with the GitHub API and I would like to implement authenticated requests to fix the problem.
Here is the output I am seeing:

> Run ksivamuthu/[email protected]
> Installing AWS Copilot...
> Error: API rate limit exceeded for 20.172.40.176. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

The code which is causing the error is here:

In the GitHub Actions CI environment, there should be a GITHUB_TOKEN environment variable which can be used to make authenticated requests.

https://docs.github.com/en/actions/security-guides/automatic-token-authentication

I will open a PR shortly.

Is it possible to add a "version" input to let me specify the copilot version?

I have issues with 1.30. Thanks!

Hi @ksivamuthu,

It seems like the latest release is not actually using the latest code. If you download the zip file and look at the /lib/main.js file, you can see that the code is for an older version.

https://github.com/ksivamuthu/aws-copilot-github-action/archive/refs/tags/v0.0.3.zip

Would it be possible to release a new build with the latest compiled code?

I am not sure what the procedure is to update the build 🤔 ..

Thank you!

What did I do wrong?

https://aws.github.io/copilot-cli/docs/commands/deploy/

More of a new feature but the ability to specify a service name for a deploy or the ability to do pipeline deploys would be great! for a deploy by name it would just take a name arg like

with:
            command: deploy
            app: app
            env: test
            name: webserver

Hi,

This action by default will load the latest, as of today, Copilot (1.30.0) which now prompts you for whether you want to deploy your environment before deploying the app. (Which is a confusing concept to me, but that's whatever.)

Anyway, all of our builds now hang on ksivamuthu/aws-copilot-github-action because it's waiting for prompt.

Issue #193 would help work around this, but it looks like this is something the action will need to be prepared for in a general sense.

Maybe more importantly: for some reason I get no visibility into this step in my Github Actions UI until I cancel the run, at which point I can see that it was just sitting and waiting interminably for a Y/N input.

If there's any way you can easily make the action properly output everything it's doing, that would help future users! 🙏

...Now off to complain to AWS, who not only broke people's automated builds but deploy process throws an error because I wrote bad YAML while following their own incorrect documentation. (Note the flip-flopping between security-group and security_group...)

Would be interested in adding an action to extract the cluster and task ID for a service?

Based on aws's response here, we can run copilot svc show --resources --json to extract the resources info. I can then reuse the output json to extract the cluster and task ID from the resources key with AWS::ECS::Service type in deploy the docker into ECS (without new version of the task) directly from github

As far as I can tell there is no way to use a github env var or secret inside the copilot manifest using this action.

This functionality is supported by copilot when using it directly.

Example manifest.yml:

image:
 build: Dockerfile
  port: 8080
  args:
    GIT_SSH_PRIVATE_KEY: ${env.GIT_SSH_PRIVATE_KEY}

This is essential for many use cases