kuanyui / moe-theme.el Goto Github PK

In order to get other settings updated accordingly when it automatically switches the theme between the light version and the dark version.

An example of what I am talking about:

The bright pink with white text makes larger blocks of changes difficult to read. Would it be possible to keep the syntax highlighting of the code when using ediff?

Hi,

I'm using fiplr, and background is incorrect.
Could it be fixed, please?

Cheers.

the title says it all. tested under mintty (256 colors under screen, everything seems to be displayed properly so i guess it's a matter of color choice rather than some bug).

don't get me wrong, i can see it, it's just that the contrast is much smaller than for that same element in moe-light, making it harder to spot. my monitor is properly calibrated, so i guess it's not only me.

Hello,

I am wondering if it is possible to add boldness as well to keywords in C/C++. That would be nice!

This is not an issue. Just a suggestion.

Possible enhancement idea:

Support rainbow-identifiers faces by adding colored faces for rainbow-identifiers-identifier-<number> (by default, rainbow-identifiers identifies 1-14, but we can customize how many faces it should use with the variable rainbow-identifiers-face-count, but the higher the number, the more useful this mode is to people).

Example code that does the customization, which I'm not submitting as a merge request because I'm not great at making the actual color choices.
inside custom-theme-set-faces:

   ;; rainbow-identifiers
   `(rainbow-identifiers-identifier-1 ((,class (:foreground ,red-2))))
   `(rainbow-identifiers-identifier-2 ((,class (:foreground ,blue-1))))
   `(rainbow-identifiers-identifier-3 ((,class (:foreground ,green-2))))
   `(rainbow-identifiers-identifier-4 ((,class (:foreground ,magenta-2))))
   `(rainbow-identifiers-identifier-5 ((,class (:foreground ,cyan-3))))
   `(rainbow-identifiers-identifier-6 ((,class (:foreground ,orange-2))))
   `(rainbow-identifiers-identifier-7 ((,class (:foreground ,purple-2))))
   `(rainbow-identifiers-identifier-8 ((,class (:foreground ,white-1))))
   `(rainbow-identifiers-identifier-9 ((,class (:foreground ,yellow-2))))

and inside custom-theme-set-variables:

`(rainbow-identifiers-face-count 9)

Hi,

I just updated the moe-theme from melpa. I found one issue, which is that in moe-dark, the foreground color for #+end_src for code blocks in org-mode is very dark:

#+end_src is above #+begin_src python :noweb-ref IGNORE but you barely see it. Could you please fix this? Thank you so much!

I'm highly interested in this mode-line, can you point me where I can find the code of it ?
Thank you!

I would suggest a lighter red or a kind of orange... The current color is difficult to read IMHO.

The BEGIN_SRC line has a bit heavy background and the END_SRC line is very hard to read at all. It would be nice to choose something more moderate, maybe similar to the suggestions here http://orgmode.org/worg/org-contrib/babel/examples/fontify-src-code-blocks.html

At least on moe-light, the git-commit-summary-face has the green background and grey foreground and it's hard to read :)

Using (setq show-paren-style 'expression) causes an error:

Debugger entered--Lisp error: (error "Invalid face" rst-level-1-face)
  internal-set-lisp-face-attribute(rst-level-1-face :height 2.0 0)
  set-face-attribute(rst-level-1-face nil :height 2.0)
  moe-theme-resize-font-size()
  moe-dark()
  moe-theme-set-color(purple)
  eval((moe-theme-set-color (quote purple)) nil)
  eval-last-sexp-1(nil)
  eval-last-sexp(nil)
  call-interactively(eval-last-sexp nil nil)
  command-execute(eval-last-sexp)

Hello

Does anyone know which face I need to set so that in the linum column, even the soft-wrapped lines are the same background? I haven't been able to find which font face it is. I want all the lighter squares in the line number column filled in.

Usually have no problem finding which font faces to edit but this one is stumping me, I can't check which one it is with C-u C-x = because it's not possible to place the cursor there.

If I use code style in a table, it will look like this. The background after the code style is rendered to be the same as the background outside the table.

When using ggtags-mode it is hard to see the project name for ggtags on the mode-line (ggtags-mode-line-project-name) because the color is too bright for the active window. For the inactive one it is OK.

It seems that the face used for this is: compilation-info-face .

如附圖，##### 和 -------- 之上標記的標題，有反白現象，造成文字對比太低，不易辨認，希望能調整參數改善。

works fine in moe-light. bash also works fine in moe-dark

Hey, thanks for this nice theme, as well as the automatic switching that depends on the time of the day which is pretty neat.

There's one detail I find annoying though, which is that the theme is redrawn every minute. This causes Emacs to redraw everything, meaning that everything will "flash" for a second or so.

Would it be possible to use something other than load-theme?
Or is it possible to make it flash less (ideally it wouldn't flash at all, but rather just change the color in-place, so to speak)?
Perhaps you could instead calculate the time when the theme should actually be changed next time, and set a timer for that? (instead of reloading the theme every minute). Obviously this approach might require some consideration for what happens when the time jumps suddenly, like when a laptop is hibernated.

I am not running Emacs in console mode, maybe the redraw isn't as noticeable there?
If you got any questions, feel free to ask.

Emacs version: GNU Emacs 24.3.50.1 (x86_64-apple-darwin, NS apple-appkit-1038.36) of 2013-11-16 on bob.porkrind.org
System: MacBook Air running OS X 10.9.1.

After your enhancements to the colours in diff-mode, I saw the colour of green-0 and decided that it may provide a more appealing region colouring than green-2.

For reference, here are the two alternatives:

green-2:

green-0:

The difference is subtle, but significant in my opinion.

Currently when installed moe-theme is not available to theme pickers like helm-themes. This is because it's not using the Emacs custom theme machinery. As the theme is Emacs 24 only there is no particular reason not to use it.

Playing around with the theme, I like it a lot so far. I threw together a gist for st in this gist.

I have a suggestion though, I think for consistency with eshell, comint-mode should get similar colours.

At current:

Vs with eshell's prompt colours:

I think that the autoload makes moe-light enabled when installing or updating, and the way it does it makes it impossible to disable the theme with "disable-theme", which leads the unwanted behavior.

It would be cool to have a dracula theme color palette in addition to moe-dark and moe-light. There's a dracula theme for emacs already, but it doesn't support the myriad of modes that moe-theme does. Plus, I like the way color is applied to highlights and different items in moe-theme. A moe-dracula option would be the best of both worlds!

it seems (powerline-moe-theme) suppose to work only with https://github.com/milkypostman/powerline
but I am using https://github.com/jonathanchu/emacs-powerline.
do I have to switch my powerline to use moe-theme?

In info-mode, only when moe-light is enabled, the header links next to 'Next:', 'Prev:' and 'Up:' are invisible.

when there are to much minor mode, the line number is pushed to the right, outside the screen and is not diplayed.
the minor mode section should be wrapped or the line number should be displayed on the left side

Currently the background color for headings in rst-mode is too light in moe-dark and it is hard to read the heading title.

I suggest the following colour changes for ace-jump-mode to help the selections stand out more. The problem with the current scheme is that the dark red is difficult to read on the dark theme.

Deactivated dark:

Activated dark (before):

Activated dark (after):

The colours used in the new version are:
ace-jump-face-background: gray40 (maybe it can be changed to black-2-5 like the comment face)
ace-jump-face-foreground: cyan-1

I am sorry to open a ticket just to thank you, but I do not see how else I could do it.

I usually use a theme either because I like it, or because it enhance my productivity. This is the first time that I can actually use a theme that I like AND that enhance my productivity.
Beautiful theme, both versions of course.

Thank you so much for it!

Please, add it to http://marmalade-repo.org/.

Thank you in advance!

Enhanced ruby mode has a few custom faces which I'd love to have added to moe-theme!

(defun erm-define-faces ()
 (defface enh-ruby-string-delimiter-face
   `((t :foreground ,(erm-darken-color font-lock-string-face)))
   "Face used to highlight string delimiters like \" and %Q."
   :group 'enh-ruby)

 (defface enh-ruby-heredoc-delimiter-face
   `((t :foreground ,(erm-darken-color font-lock-string-face)))
   "Face used to highlight string heredoc anchor strings like <<END and END"
   :group 'enh-ruby)

 (defface enh-ruby-regexp-delimiter-face
   `((t :foreground ,(erm-darken-color font-lock-string-face)))
   "Face used to highlight regexp delimiters like / and %r."
   :group 'enh-ruby)

 (defface enh-ruby-op-face
   `((t :foreground ,(erm-darken-color font-lock-keyword-face)))
   "Face used to highlight operators like + and ||"
   :group 'enh-ruby)

 (defface erm-syn-errline
   '((t (:box (:line-width 1 :color "red"))))
   "Face used for marking error lines."
   :group 'enh-ruby)

 (defface erm-syn-warnline
   '((t (:box (:line-width 1 :color "orange"))))
   "Face used for marking warning lines."
   :group 'enh-ruby))

Hi!

Thank you for the moe-themes, they are very nice. I use them when I'm on OSX. I installed them via M-x package-list-packages, and I have Cask and Pallet installed. In OSX, I can do M-x load-theme and I will see moe-light and moe-dark in the list of themes, but I do not see them in the list on Gentoo.

I do not know how to fix it, please let me know if you have any idea.

Hi,

This happens for some themes but not for others. With moe-theme, in magit's diff buffer, the selected hunk (where the cursor is)'s highlight changes to grey background and white fonts (Loses green for addition and red for removal), like the following screenshot:

This makes things very hard to read. Some other themes change the background of the selected hunk but keeps the syntax highlighting:

It would be great if moe-theme also just highlight the selected hunk with a different background color, but maintains the syntax highlighting.

Thank you!

I am using moe-dark theme on org-mode. But I found "#+BEGIN_SRC" and "#+END_SRC" are in different color and the later one can be barely seen

Hello,

I installed moe thems though the package list. And I put this in my .emacs file:

(add-hook 'after-init-hook
           '(lambda ()
              (load-theme 'moe-light)))

The problem is that I cannot use moe's commands such as changing the mode color. If I replace it with this:

(add-hook 'after-init-hook
           '(lambda ()
              (load-theme 'moe-light)
              (load-theme 'moe)))

It works fine, but when I starts emacs, it says that the custom theme moe does not exists.

if I replace the whole thing with just

(moe-light)

I get an error that moe is not defined.

Anyone knows why?

The readability of font-lock-preprocessor-face using the dark theme is fairly low, the colour should probably be changed back to purple-1 for the dark theme, but purple-2 for the light theme seems to work well.

When I update moe-theme, emacs automatically loads it.

Is there a way to stop that?

Hi,

I just updated the theme to 20150307.1907 from melpa. When I'm restarting Emacs, I'm getting the following error:

Debugger entered--Lisp error: (void-variable left)
  powerline-reset()
  require(powerline nil :no-error)
  byte-code("\300\301\302\303#\203�

(For some reason I cannot copy the the full traceback)

Powerline got updated to (to 20150312.2049), but even when I comment out all the powerline stuff in my init file and have (require 'moe-theme) only, I still get the same error.

Byte compiler returns:

moe-theme-switcher.el:78:19:Warning: assignment to free variable ‘24h/sunrise’
moe-theme-switcher.el:79:19:Warning: assignment to free variable ‘24h/sunset’

In switch-by-locale:
moe-theme-switcher.el:97:14:Warning: reference to free variable ‘24h/sunrise’
moe-theme-switcher.el:112:39:Warning: reference to free variable ‘24h/sunset’
moe-theme-switcher.el:136:7:Warning: assignment to free variable ‘moe-timer’

In moe-theme-switcher-disable:
moe-theme-switcher.el:141:17:Warning: reference to free variable ‘moe-timer’

In end of data:
moe-theme-switcher.el:146:1:Warning: the function ‘second’ is not known to be
    defined.

Could you please fix these warnings? Last one is probably because there is no (require 'cl).

Please get the point of this issue by view pictures attached below:

Also, please let me know if it's my emacs config problem.Thanks!

That would be great!

I might customize it soon so I post my choices here.

https://github.com/nschum/highlight-symbol.el

Hi Kuanyui,

I like your theme, thank you very much!

However, as I was trying to change the default foreground color to black-6, I noticed that the foreground color has been hard coded in the function moe-light. I've seen you explanation a few lines before, however, I'm not sure whether that affects only the background color. If so, do you think we should remove the line that hard coded the foreground color?

Thank you

moe-dark:

moe-light:

The top one is hard to read. Do you know of any way to improve this?

Moe-light refine-hunk faces are not contrasting enough with normal diff faces. It'd be great to improve that (diff-mode).

Hi,

Thanks for the great theme. I'm using the following options to resize titles:

(setq moe-theme-resize-markdown-title '(1.5 1.4 1.3 1.2 1.0 1.0))
(setq moe-theme-resize-org-title '(1.5 1.4 1.3 1.2 1.1 1.0 1.0 1.0 1.0))
(setq moe-theme-resize-rst-title '(1.5 1.4 1.3 1.2 1.1 1.0))

I found that with (moe-light), resizing does not work, while it works fine with (moe-dark). But when I eval (moe-dark) first, and then eval (moe-light), then resizing is correctly applied.

Hi,
i write a function to return a string (is color name) from list look like:

'(red green blue yellow purple magenta)

(defun random-color (lst)
  "random color from a list."
  (nth (random (length lst)) lst)
  )

I used the list for random-color () function and it generate random color name. But when i apply setting:

(moe-theme-set-color 'color-name) to change color for mode-line like bellow:

(moe-theme-set-color '(random-color '(red green blue yellow purple magenta)))

but it not working, the default color (blue) was applied, i cant see any error.
Pls help me.

Hi,

I am using moe-light with CEDET and stickyfunc-mode enabled.
(add-to-list 'semantic-default-submodes 'global-semantic-stickyfunc-mode)

Background color for this sticky header is a little bit too dark.

When you install the moe-theme from MELPA, for some reason the light theme gets loaded. I feel that a theme should not do this.

I like your idea for a day and nigh theme, but would you at all consider making that functionality its own package that is not integrated wit the theme? That is you could easily make a minor-mode that simply has two variables—possibly daytime-theme and nighttime-theme—and sets the themes accordingly?

Then when this minor mode s activated, the theme choice is ignored.

I mean, the bigger issue is that I should be able to install just the moe-themes (light and dark) without having to worry about the day and night code.

the color theme is beautiful
but the contrast is little bit too high between foreground and background
it would be nice if you can add an option to lower the contrast

also, i suggest to make comments italic. :)

I like this font 👍