kuartz-org / vitrail Goto Github PK

I find referencing component constant everywhere cumbersome and a bit of lost space, and I'd like to implement a kind of helper I already used on an app of mine.

<div>
  <%= render vitrail.title(level: 2).with_content("Hello there!") %>

  <%= render vitrail.card(class: "bg-blue-200") do %>
    <p>What a nice gem!</p>
  <% end %>
</div>

In Vitrail::BaseComponent, initialize is:

def initialize(**html_options)
  super

  @custom_classes = html_options.delete(:class) || ""
  @html_options = html_options.stringify_keys
end

but by doing so, the html_options is mutated and key :class is removed. It could cause unexpected behavior in such examples:

<div>
  <% html_options = { class: "text-red-500", data: { some_stimulus_target: "target" } %>
  <% @elements.each do |element| %>
    <%= render Vitrail::Card.new(**html_options).with_content(element.content) %> <!-- class is not passed after first element-->
  <% end %>
</div>

In this case, after the first iteration, hash hold by html_options variable is mutated and :class key is remove.
I can see this method comes from Rails codebase but when it is done like, hash is cloned before being mutated.

Edit: I made a PR with a fix #4