kubernetes-sigs / community-images Goto Github PK

Someone who cannot see red apart from green may struggle to use this tool. We could, eg, append ⚠️ ⚠️ emoji to list the problem images.

from @sftim https://kubernetes.slack.com/archives/CCK68P2Q2/p1677504360890739?thread_ts=1677416006.142059&cid=CCK68P2Q2

For example, in this case, we only show k8s.gcr.io/library/liveness:darkness

Optionally: list the namespaces where there is at least one problem Pod / pod template.

from @sftim https://kubernetes.slack.com/archives/CCK68P2Q2/p1677504435388339?thread_ts=1677416006.142059&cid=CCK68P2Q2

The parser makes an incorrect assumption that library is an implicit namespace on all hosts, this is only true for docker.io / when docker.io is defaulted.

This is visible in the sample output in the README:

registry.k8s.io/library.* examples are wrong

/assign

https://github.com/dims/community-images/blob/572f1f579be0a510e026f70b8173abb2cbd44465/.github/workflows/go.yml#L23

go: go.mod file indicates go 1.19, but maximum version supported by tidy is 1.18

https://github.com/johanneskastl/community-images/actions/runs/4303393509/jobs/7503072657

Now that #19 is in, could you please tag a new release?

right now all images are given ❌ or ✅ based only on if they're on a non-deprected host or else a non-kubernetes-project host.

for registry.k8s.io we could use a tool to print a list of images the user should mirror, it seems like we have most of the infrastructure here already.

is this something that makes sense, or something we should do elsewhere?

we'd probably also want an option like -q / --quiet to just print one mirror-worthy image per line, deduped, with no other formatting for piping to scripts, vs a fancy mode for human viewing

We should also consider flagging usage of backing hosts from k8s.gcr.io and the ARs behind registry.k8s.io

WDYT @dims?

These were never supported, but I bet lots of clusters use them, and they should switch to registry.k8s.io or their mirror instead.

I think the current phrasing is slightly misleading when it says "❌ are being pulled from Kubernetes community registries" and "✅ are good as they are NOT from Kubernetes community registries"

registry.k8s.io is to me a "kubernetes community registry" but shows up as green.

Maybe we can say something like: "Images in red ❌ are being pulled from outdated Kubernetes community registries. The Others marked in green ✅ are good as they do not use the outdated registries."

And consider adding gcr.io/google-containers to the list of outdated registries.