kucera-lukas / rusty-battery Goto Github PK

Add unit tests to make sure that mainly the lower level functions work as expected.

Even though https://github.com/doublify/pre-commit-rust is useful, the inability the specify arguments to clippy makes it useless as it won't check all-targets (eg. tests)

If no other alternative is found, custom hooks should be created.

dtolnay/rust-toolchain is a fork of the original actions-rs/toolchain but more up to date.

Low level code should not panic, it should propagate errors and let the caller handle them.

Binaries should be built every a new release is made and should be saved as an artifact of the action.

• #28
• Add subcommand to list all available KDE Connect devices like in #23

This should probably be done via codecov and data should be uploaded via GitHub actions.

Set up GitHub pages for documentation.

The CLI Notify subcommand should have a new option to allow the user to specify the delay between battery refresh and possible notification event.

This option should have a default so it can be ommitted.

• minimize the usage of kdeconnect-cli as it is very inefficient
• speed up the searching process when given multiple KDE Connect device names

Add option to ping chosen mobile devices with information about battery charging status.

The kdeconnect-cli tool should probably be used, unless there is some other handy library for KDE Connect.

Desktop notification can sometimes fail with this error:
[WARN] - something went wrong with desktop notification: org.freedesktop.DBus.Error.NameHasNoOwner: Could not activate remote peer.

Lint, test and release

Instead of reading current battery percentage via upower command, we should use more generic interface for different operating systems. The rust-battery crate is exactly what is needed.

GitHub workflows are now trigger on push events to the master branch but the base branch of this repository is called main.

• warning message should be created only once
• notifiers should not have internal state if they don't need it

Information about sent notifications, current battery and others should be shown to the user.

KDE Connect notification interface should not collect all devices at startup. Better solution is to ping all available devices during the notification event.

#27

Setup dependabot alongside with #4

error.rs file should contain the application error definition.

This should probably be done via a CLI subcommand. It should collect battery models of each battery device and print them to the terminal along with their current state of charge to help user identify which one is the one which is in use by their device.

Create .pre-commit-config.yml for linting on commit.

GitHub actions should be used to make sure that all files adhere to the code style defined in pre-commit-config.yaml in combination with #4