kush-agra / dynamic_walls Goto Github PK

First of all, the wallpaper files seem to be sorted and numbered in the wrong order. If you follow the light and the shadows on the dune, this is easy to spot. I believe the correct order is:

• 002 (dawn)
• 003 (sunrise)
• 004 (daybreak)
• 005
• 006
• 007
• 008 (noon)
• 009
• 010
• 011
• 001
• 012 (sunset)
• 013 (dusk)
• 016 (nightfall)
• 015
• 014

I'm not sure if you've already noticed this and compensate by not displaying the images in their numbered order, but the script's display order is currently inconsistent to both the numbering and the actual order. For example, 008 appears after 009, 009 then repeats after 008 and 013 appears after 011 (my location: Berlin; 24h time).

I have also noticed that the timing of the changes does not correspond well to moments like sunset, sunrise, dusk, dawn, and the time periods are quite unevenly spaced. For example: 013 appears over 5.5 hours after the previous image, while other periods are much shorter, and 014 appears long after nightfall.

Many thanks for creating and updating this script!

How can I stop the script before switching to the app version or just updating it?

Thanks for the nice GitHub repo containing the scripts. It works as described but I have an issue.
I usually work with 4 virtual desktops/spaces and when the script is run only the current/active desktop is changed, the others remain unchanged.
There is a way to apply the same wallpaper on all the virtual desktops/spaces.

On the first of the month, the sunsetDate is 31, and the currentDate is 1. The script only checks if sunsetDate is less than currentDate, but this logic breaks down on the first of the month when the previous day is a greater number than the current day.

This results in the wrong wallpaper being displayed.

if (sunsetDate < currentDate) then
	set sunsetTime to sunsetTime + 86400
else if (sunsetDate > currentDate) then
	set sunsetTime to sunsetTime - 86400
end if

Change sunrise to twilight start for a better experience

I tried the new launchd generator, but there were some mistakes:
Line 14 instead of:
<string>/Users/var/Pictures/Wallpapers/Dynamic_Walls.scpt</string> it should be: <string>/Users/$var/Pictures/Wallpapers/Dynamic_Walls.scpt</string>
Line 23 instead of: </plist>" > /Users/$var/Library/LaunchAgents/Dynamic_walls.Scheduler.plist it should be: </plist>" > /Users/$var/Library/LaunchAgents/wallpaper.plist

EDIT: Example:
wallpaper_plistGenerator.zip

Is there a particular reason you suggest using a cron job to run the script at an interval? Cron is typically not used anymore, in favor of launchd. Launchd allows the script to execute while the system is asleep, and on wake. You can also specify the interval without using a nano editor to change it. I've included an example plist with a 10 minute interval and a run on wake parameter as well. This should be placed in the LaunchDaemon folder if you want it to run whether you're logged in or not, or LaunchAgents if you only want it running while logged in.

You'll need to use a text editor to specify the path of the script inside the plist, then save it as wallpaper.plist instead of .txt. Once inside the Library/LaunchDaemons folder, you'll use the terminal command "launchctl load /PATH/TO/PLIST" to load the launchd file.

wallpaper.txt

Let me know what you think, the script works great so far!

Edit: More specific instructions.

There seems to some issue where the shell script would sometimes return a "No JSON object could be decoded" error, usually at the 59th minute

although it doesn't affect the script negatively in anyway as it starts working again the next minute, what seems to be causing that, my guess is it's the API crapping out?

I've deleted all the files. But now Terminal keeps telling me that I have unread mail which contains errors about missing or whatever like that. How to completely disable it? I've used alpha version which was installed with terminal in 3rd step. Help me

Use the solar noon time returned by the API to set mojave_dynamic - 008.jpg wallpaper instead of custom logic

So I probably should not have been messing with things like this yet as I am pretty basic in my coding knowledge. I have deleted everything related to this, but my theme seems to be stuck on dark mode even after changing the command to false in the script.

How do I get this off, or kill it all in terminal? And also when the actual Mojave update comes out, will this mess that up?

Need help

First, I love your script!

It would be nice to see the wallpaper fading between images instead of just switching. If I create a folder on System Preferences and mark to change a picture every X time they also fade. Must be something built-in the system. Wallpaper Wizard also do that.

Thanks!